Feature/code documentation #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
216
to
222
| function claimFee() external nonReentrant onlyAdmin { | ||
| uint256 penaltyAmount = pool.totalPenalties; | ||
| if (penaltyAmount == 0) revert NothingToClaim(); | ||
| pool.totalPenalties = 0; | ||
| IERC20(pool.rewardToken).safeTransfer(pool.adminWallet, penaltyAmount); | ||
| emit FeeClaim(penaltyAmount); | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
Comment on lines
216
to
222
| function claimFee() external nonReentrant onlyAdmin { | ||
| uint256 penaltyAmount = pool.totalPenalties; | ||
| if (penaltyAmount == 0) revert NothingToClaim(); | ||
| pool.totalPenalties = 0; | ||
| IERC20(pool.rewardToken).safeTransfer(pool.adminWallet, penaltyAmount); | ||
| emit FeeClaim(penaltyAmount); | ||
| } |
Check notice
Code scanning / Slither
Block timestamp Low
contracts/RequestManager.sol
Outdated
Comment on lines
41
to
54
| function deploy(uint256 id) external { | ||
| if (requests.length <= id) revert InvalidId(); | ||
| Request memory req = requests[id]; | ||
| if (req.requestStatus != Status.APPROVED) revert InvalidRequestStatus(); | ||
| if (msg.sender != req.data.deployer) revert InvalidDeployer(); | ||
| requests[id].requestStatus = Status.DEPLOYED; | ||
| address newPoolAddress = IGenericFactory(req.data.factory).deploy( | ||
| req.data.deployer, | ||
| req.data.stakingData | ||
| ); | ||
| stakingPools.push(newPoolAddress); | ||
| poolById[id] = newPoolAddress; | ||
| emit RequestFullfilled(id, newPoolAddress); | ||
| } |
Check notice
Code scanning / Slither
Reentrancy vulnerabilities Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #50 +/- ##
========================================
Coverage 86.81% 86.81%
========================================
Files 12 12
Lines 546 546
Branches 142 142
========================================
Hits 474 474
Misses 70 70
Partials 2 2 ☔ View full report in Codecov by Sentry. |
…tsu/stakepad-contracts into feature/codeDocumentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.