-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] 소개페이지 업데이트 #410
Merged
Merged
[Feat] 소개페이지 업데이트 #410
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1259e0f
chore: 임원진 image 업로드
wuzoo b7b1605
style: core value img style 수정
wuzoo 433c4de
chore: 34 -> 35, 임원진 정보 업데이트
wuzoo afe4264
feat: use client in Content Component
wuzoo 32ba3b7
chore: ci test
wuzoo 7c99149
chore: img size resizing
wuzoo da27484
chore: text, color 수정
wuzoo 51c5c50
chore: 코리 반영
wuzoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,113 +51,118 @@ const getMemberInfo = async (): Promise<GetMembersInfoResponse> => ({ | |
members: [ | ||
{ | ||
id: 1, | ||
name: '조승우', | ||
name: '정건', | ||
position: '회장', | ||
currentProject: '성균관대학교', | ||
description: '솝트의 지금, 여러분과 함께', | ||
currentProject: '건국대학교, 티키', | ||
description: '동아리, 그 이상의 가치', | ||
imageSrc: '/images/members/1.png', | ||
gmail: '[email protected]', | ||
linkedin: 'seungwoo-cho-7a5676236', | ||
}, | ||
{ | ||
id: 12, | ||
name: '김송이', | ||
position: '부회장', | ||
currentProject: '아주대학교', | ||
description: '빛나는 열정을 펼칠 수 있도록', | ||
imageSrc: '/images/members/12.png', | ||
gmail: '[email protected]', | ||
github: 'sjk4618', | ||
}, | ||
{ | ||
id: 2, | ||
name: '박세은', | ||
name: '윤영서', | ||
position: '총무', | ||
currentProject: '한양대학교, doorip', | ||
description: '나와 우리의 성장을 위해 파이팅!', | ||
currentProject: '동국대학교, doorip', | ||
description: '열정을 쏟을 이곳에서 동료들과', | ||
imageSrc: '/images/members/2.png', | ||
gmail: '[email protected]', | ||
github: 'seeunplayer', | ||
linkedin: 'tina-park-755ab8230', | ||
github: '0seoYun', | ||
}, | ||
{ | ||
id: 5, | ||
name: '곽성준', | ||
name: '이현진', | ||
position: '운영 팀장', | ||
currentProject: 'doorip', | ||
description: '잊지 못할 추억을 드립니다.', | ||
currentProject: '가톨릭대학교, dateroad', | ||
description: '매 순간을 소중한 추억으로!', | ||
imageSrc: '/images/members/5.png', | ||
gmail: '[email protected]', | ||
github: 'sjk4618', | ||
github: '2hyunjinn', | ||
}, | ||
{ | ||
id: 4, | ||
name: '정채은', | ||
name: '방민지', | ||
position: '미디어 팀장', | ||
currentProject: 'YELL:O, PINGLE', | ||
description: '이상적인 기억을 기록합니다.', | ||
currentProject: 'PINGLE', | ||
description: '우리의 발자취를 기록하다.', | ||
imageSrc: '/images/members/4.png', | ||
gmail: '[email protected]', | ||
github: 'chaentopia', | ||
github: 'bangMinjI98', | ||
}, | ||
{ | ||
id: 3, | ||
name: '정동규', | ||
name: '김가연', | ||
position: '메이커스 팀장', | ||
currentProject: 'palmspring', | ||
description: '하고 싶은건 모두 도전합니다.', | ||
currentProject: '이화여자대학교, OFFROAD', | ||
description: 'SOPT다움을 찾아서', | ||
imageSrc: '/images/members/3.png', | ||
gmail: '[email protected]', | ||
github: 'yummygyudon', | ||
linkedin: 'yummygyudon', | ||
}, | ||
{ | ||
id: 6, | ||
name: '여민서', | ||
name: '김소희', | ||
position: '기획 파트장', | ||
currentProject: 'YELL:O, 하면함', | ||
description: '성장에 미쳐있는 사람', | ||
currentProject: '성신여자대학교', | ||
description: '함께라면, 어떤 꿈도 현실이 됩니다', | ||
imageSrc: '/images/members/6.png', | ||
gmail: '[email protected]', | ||
}, | ||
{ | ||
id: 7, | ||
name: '황현진', | ||
name: '송예솔', | ||
position: '디자인 파트장', | ||
currentProject: 'growthook, doorip', | ||
description: '디자인의 지니어스', | ||
currentProject: 'Lecue, 선약', | ||
description: '세상을 바꾸는 디자이너들', | ||
imageSrc: '/images/members/7.png', | ||
gmail: '[email protected]', | ||
}, | ||
{ | ||
id: 8, | ||
name: '곽의진', | ||
name: '배지현', | ||
position: '안드로이드 파트장', | ||
currentProject: 'pophory, 하면함', | ||
description: '인간 안드가 되어봅시다.', | ||
currentProject: '건빵, PINGLE, dateroad', | ||
description: '함께의 힘을 믿습니다.', | ||
imageSrc: '/images/members/8.png', | ||
gmail: '[email protected]', | ||
github: 'KwakEuiJin', | ||
github: 'jihyunniiii', | ||
}, | ||
{ | ||
id: 9, | ||
name: '류희재', | ||
name: '한지석', | ||
position: 'iOS 파트장', | ||
currentProject: 'ZOOC', | ||
description: '낭만 사과 꽃길 같이 걸어가요', | ||
currentProject: '수원대학교, Recordy', | ||
description: '나는 더 나은 미래를 위해 싸운다', | ||
imageSrc: '/images/members/9.png', | ||
gmail: '[email protected]', | ||
github: 'HELLOHIDI', | ||
github: 'sozohoy', | ||
}, | ||
{ | ||
id: 10, | ||
name: '이재훈', | ||
name: '유태승', | ||
position: '웹 파트장', | ||
currentProject: 'ASAP, Mile', | ||
description: '소속감에 미쳐있는 사람', | ||
currentProject: '건국대학교, PICKPLE', | ||
description: '저와 함께 도약할 준비 되셨나요?', | ||
imageSrc: '/images/members/10.png', | ||
gmail: '[email protected]', | ||
github: 'ljh0608', | ||
github: 'gudusol', | ||
}, | ||
{ | ||
id: 11, | ||
name: '도소현', | ||
name: '계대환', | ||
position: '서버 파트장', | ||
currentProject: '이화여자대학교', | ||
description: '단단한 서비스를 제공합니다.', | ||
currentProject: 'smeem', | ||
description: '부드럽고, 성실하고, 능숙하게', | ||
imageSrc: '/images/members/11.png', | ||
gmail: '[email protected]', | ||
github: 'sohyundoh', | ||
}, | ||
], | ||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이미지 크기와 실제 렌더링 되는 사이즈 간격이 많이 차이가 나네요
이러면 성능 안 좋아질 수 있으니 2~3배 정도로 뽑으면 될 거 같아요 :)
(사진이 작아서 2배 정도만 해도 될 듯 합니다)
사이트가 필요하시면 여기 이용하시면 될 거 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 그러네요 한 사진당 1MB가 다 넘어가서🫨🫨🫨🫨 제 PR에도 너무 rich 하다고 안떠요 ㅠㅠ (주용님 컴의 문제가 아니엇네요)
그리고 로컬에서 실행해도 이미지들이 안받아와져서 먼진선생님들 얼굴도 34기분들로 뜨네여 ㅠㅠ
꼭 줄여야할 것 같슴두 이미지 리사이징 하시고 다시 불러주시면 확인해보겠습니당