[SP3] 메인 하단 레이아웃 #324
Merged
[SP3] 메인 하단 레이아웃 #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rever0
approved these changes
Dec 20, 2023
Comment on lines
+7
to
+10
| function ActivitySection(_props: unknown, ref: React.Ref<HTMLDivElement>) { | ||
| return ( | ||
| <S.Wrapper id="activity" ref={ref}> | ||
| <Activity /> |
There was a problem hiding this comment.
Activity 컴포넌트에 활동 내역이 담겨있어서 Activity라고 명을 지었는데, 메뉴에서 활동/파트/자체기구를 합친 명이 Activity 군요..!
메뉴명과 동일하게 ActivitySection은 유지하는게 맞는 것 같고 Activity 컴포넌트 명을 변경하면 좋을 것 같은데, 어떻게 생각하시나요?!
| const { scrollYProgress } = useScroll({ target: targetRef, offset: ['start center', 'start'] }); | ||
|
|
||
| const viewList = [false, activity.isInView, review.isInView, news.isInView]; | ||
| const minIndex = viewList.findIndex((value) => value === true); |
There was a problem hiding this comment.
intersectionObserver를 사용해서 현재 위치한 섹션의 메뉴명에만 색이 들어오게 하고 있는데 viewport에 두 가지 섹션이 한번에 들어왔을 경우 앞에 있는 섹션에만 색이 들어오도록 하기 위해서 작성한 코드입니다!
|
|
||
| function ActivitySection(_props: unknown, ref: React.Ref<HTMLDivElement>) { | ||
| return ( | ||
| <S.Wrapper id="activity" ref={ref}> |
There was a problem hiding this comment.
피그마 해당 섹션 위에 여백이 있는데 현재 작업에는 없더라구요..!
작업물 합치고, 헤더 작업을 할때 수정해야할 부분인 것 같습니다!
* feat : 액티비티 컨텐츠 내용 변경 * feat : useInfiniteCarousel 적용 * chore : 불필요한 style 삭제 * chore : 불필요한 type 제거 * chore : 불필요한 style 삭제
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot