[SP2] 최근 출시된 프로젝트 추가 #310
Merged
[SP2] 최근 출시된 프로젝트 추가 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeojinSeojin
reviewed
Dec 5, 2023
| import { ProjectCategoryType, ProjectPlatformType, ProjectType } from '@src/lib/types/project'; | ||
| import RecentProjectListItem from '@src/views/ProjectPage/components/RecentProjectList/Item'; | ||
| import { useGetProjectList } from '@src/views/ProjectPage/hooks/queries'; | ||
|
|
||
| export default function RecentProjectListCarousel() { | ||
| const { data } = useGetProjectList(ProjectCategoryType.ALL, ProjectPlatformType.ALL); | ||
| const recentProjectList = data as ProjectType[]; |
There was a problem hiding this comment.
요거 받은 프로젝트만 띄우고, useGetProjectList에서 받은 data는 쓰지 않도록 하면 어떨까요..?!?
There was a problem hiding this comment.
헣 이 부분은 PM이랑 PD 의견이 지금 다른 것 같아서 답변 기다리고 있는 상태입니다..!!
https://sopt-makers.slack.com/archives/C042T8GEA0Y/p1701614764413939
There was a problem hiding this comment.
신청하는 프로젝트들만 상단 노출하는 걸로 결론이 나서 useQuery 사용 코드는 지웠습니다!!
SeojinSeojin
reviewed
Dec 5, 2023
src/lib/constants/project.ts
Outdated
| @@ -41,3 +48,35 @@ export const pageBreakPoint: Record<PageType, string> = { | |||
| [PageType.BLOG]: '767px', | |||
| [PageType.PROJECT]: '899px', | |||
| }; | |||
|
|
|||
| export const StaticReleaseProjectList: StaticProjectType[] = [ | |||
There was a problem hiding this comment.
요것은 변수인 것 같아서, 소문자로 시작하면 좋을 것 같습니다..!!
SeojinSeojin
reviewed
Dec 5, 2023
| select: (data) => (sortType ? sortBy<ProjectType>(data, 'updatedAt') : data), | ||
| select: (data) => { | ||
| const filteredData = data.filter(({ link }) => | ||
| link.some(({ title }) => ['website', 'appStore', 'googlePlay'].includes(title)), |
There was a problem hiding this comment.
이미 요런 처리를 해주셨군여.. 그럼 이대로 가도 좋을 것 같습니다!!
There was a problem hiding this comment.
호옥시 요런 필터 처리가 전체 프로젝트 목록에 영향을 주는지 한번만 봐주심 감사하겠습니다..!!! 제 기억으로는 ProjectPage에서도 사용하는 훅이여서요!!
There was a problem hiding this comment.
으아 이런 실수를... 수정하겠습니다..!!! 감사해요
SeojinSeojin
pushed a commit
that referenced
this pull request
Dec 5, 2023
* asset: 프로젝트 로고 이미지 추가 * feat: 최근 출시된 프로젝트 정적 데이터 추가 * feat: 디바이스 타입에 맞는 링크 보여주기 * feat: 링크가 있는 프로젝트만 보여주기 * chore: 코드 리뷰 반영 * fix: 정적 데이터만 보여주도록 수정 * fix: 데이터 필터링 코드 제거 --------- Co-authored-by: solar3070 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Comment