Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP2] CI 에러 고치기, 리크루팅 탭 활동후기 복원 #268

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

SeojinSeojin
Copy link
Member

@SeojinSeojin SeojinSeojin commented Nov 9, 2023

Summary

CI 워닝이 뜨던 것을 고쳤습니다!

image

Screenshot

image 리크루팅 탭의 활동 후기 부분이 주석으로 봉인되어 있더라고요 ..!! 그것으로부터 풀어주었습니다. 혹시 이것의 히스토리를 아시는 분이 있으신가요? 봉인을 해제해도 되는게 맞는지 알아봐야 할 것 같아요

Comment

  • useBooleanState 훅을 사용하면, 그것이 리턴하는 setTrue, setFalse 함수를 useEffect에서 호출했을 때 의존성 배열에 넣어주어야 하네요 .. 그런데 의미상 필요하지 않은 것 같아서 useState를 쓰는 코드로 변경했는데, 더 좋은 해결방법이 있다면 말씀해 주시면 감사하겠습니다!

Copy link
Member

@solar3070 solar3070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useState 사용하신 거 저는 좋습니다~!~!

@f0rever0 @SeojinSeojin
저희 React Hook useEffect has a missing dependency 린트 오류 뜨는 곳이 꽤 있는데 신경쓰면 좋을 것 같습니다! [관련 문서]

Copy link
Contributor

@f0rever0 f0rever0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 확인했습니다!!

@SeojinSeojin SeojinSeojin merged commit 0ba326f into develop Nov 9, 2023
1 check passed
@SeojinSeojin SeojinSeojin deleted the feat/#267_fix-ci-warning branch November 9, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Warning 제거
3 participants