-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SP2] blog tab navigation #228
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
7145e8a
feat : blog 탭 생성
f0rever0 8bbcfe5
style : change header style
f0rever0 94a89ee
feat : 블로그 탭 네비게이션
f0rever0 12efe7d
style : 전체적인 컬러 코드 변경
f0rever0 78c2717
feat : blog 탭 생성
f0rever0 80adbca
style : change header style
f0rever0 c10ea97
feat : 블로그 탭 네비게이션
f0rever0 9c116aa
style : 전체적인 컬러 코드 변경
f0rever0 d9ea44c
Merge branch 'feat/#218-blog-tab-navigation' of https://github.com/so…
f0rever0 88ae4c1
refactor : change to inline export
f0rever0 4c2e5f6
refactor: apply color systems
f0rever0 babab4f
style : header 선택한 탭에 밑줄
f0rever0 85aa5ef
fix : change constant color
f0rever0 5c178a1
fix : blog tab mobile boder style
f0rever0 8966d63
fix : blog tab description
f0rever0 7dc7385
feat : blog 탭 생성
f0rever0 43776ca
style : change header style
f0rever0 8f2e09a
feat : 블로그 탭 네비게이션
f0rever0 dc3d174
style : 전체적인 컬러 코드 변경
f0rever0 51d8a5e
feat : blog 탭 생성
f0rever0 190d379
refactor : change to inline export
f0rever0 c02989e
refactor: apply color systems
f0rever0 2064b1e
style : header 선택한 탭에 밑줄
f0rever0 51d8f9a
fix : change constant color
f0rever0 d0557d7
fix : blog tab mobile boder style
f0rever0 5c31a0d
fix : blog tab description
f0rever0 bb6d10a
style : change tab style
f0rever0 6058f69
Merge branch 'feat/#218-blog-tab-navigation' of https://github.com/so…
f0rever0 59cc555
fix : color 상수 코드 사용
f0rever0 7f2037a
style : footer color 상수로 바꾸기
f0rever0 74553a9
refactor : change folder name
f0rever0 3f1bfb4
feat : tab description 어절 단위 줄바꿈
f0rever0 afe94b6
chore : sopt color libaray 적용
f0rever0 dc96bc5
style : header 디자인 변경
f0rever0 5423574
feat : add blog tab title hover style
f0rever0 1ed8aaf
chore : blogTab 변수명 수정
f0rever0 173801f
Merge branch 'develop' into feat/#218-blog-tab-navigation
f0rever0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,18 @@ | ||
import { useIsDesktop, useIsMobile, useIsTablet } from '@src/hooks/useDevice'; | ||
import DesktopHeader from './Desktop/DesktopHeader'; | ||
import MobileHeader from './Mobile/MobileHeader'; | ||
import styles from './header.module.scss'; | ||
import * as S from './style'; | ||
|
||
export function Header() { | ||
const isDesktop = useIsDesktop('992px'); | ||
const isTablet = useIsTablet('766px', '991.9px'); | ||
const isDesktop = useIsDesktop('940px'); | ||
const isTablet = useIsTablet('768px', '939px'); | ||
const isMobile = useIsMobile(); | ||
|
||
return ( | ||
<header className={styles.wrapper}> | ||
<S.Wrapper> | ||
{isDesktop && <DesktopHeader />} | ||
{isTablet && <MobileHeader />} | ||
{isMobile && <MobileHeader />} | ||
</header> | ||
</S.Wrapper> | ||
); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋네용.. 사실 이제 MenuTapType.Anchor 도 사라지긴 해서 type 이라는 친구도 없어도 되긴 혀요
다른 것이 추가될 수도 있으니 살려두어도 괜찮을 것 같습니당
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MenuTapType.Anchor 도 지울까 했는데,,, 일단 살려뒀습니다!