[SP1] Amplitude 설정 #189
Merged
[SP1] Amplitude 설정 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f0rever0
approved these changes
Sep 19, 2023
src/hooks/useAmplitude.ts
Outdated
| const AMPLITUDE_API_KEY = process.env.NEXT_PUBLIC_AMPLITUDE_API_KEY; | ||
|
|
||
| function useAmplitude() { | ||
| const [amplitude, setAmplitude] = useState<typeof import('@amplitude/analytics-browser')>(); |
There was a problem hiding this comment.
import한 값을 typeof 로 바로 지정할 수도 있군요 !!
src/hooks/useAmplitude.ts
Outdated
| const [amplitude, setAmplitude] = useState<typeof import('@amplitude/analytics-browser')>(); | ||
|
|
||
| useEffect(() => { | ||
| const initAmplitude = async () => { |
There was a problem hiding this comment.
init은 한 페이지에서 한 번만 불려도 될 것 같은데요 ..!!
만약 페이지 하나가 컴포넌트 3개를 거느리고 있고, 각 컴포넌트에서 useAmplitude를 호출하면, initAmplitude가 3번 호출되어서 amplitudeModule.init도 3번 호출되고, 그러면 view_${pageName}도 3번 찍히게 될 것 같습니다 ..!!!
(훅 관련한 기억이 긴가민가해서 틀린 추측일 수도 있습니다!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot
[chrome extension 캡쳐]
크롬 익스텐션 설치를 권장합니다! 이벤트 로그를 편하게 볼 수 있습니다.
Comment
.env.development,.env.production으로 나누었습니다. 알려드린 앰플리튜드 키를 각각 넣어주세요!click_main_part,click_main_activity,click_review_part이벤트를 트래킹했습니다. 참고해서 작성해주시면 됩니다.