Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP0] Recruit 탭 추가 #157

Merged
merged 13 commits into from
Sep 11, 2023
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"@types/qs": "6.9.7",
"axios": "^0.27.2",
"classcat": "^5.0.4",
"googleapis": "126.0.0",
"nanoid": "4.0.2",
"next": "13.3.0",
"qs": "6.11.1",
Expand Down
181 changes: 177 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/assets/icons/ic_arrow_right_white.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions src/assets/icons/ic_email.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions src/assets/icons/ic_facebook.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions src/assets/icons/ic_kakao.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/icons/img_instagram.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/assets/images/img_mainvalue_logos.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions src/components/Header/Desktop/DesktopHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,11 @@ const menuTitleUnderline = css`
width: 100%;
border-bottom: 2px solid white;
}
&:last-child {
&::after {
width: calc(100% + 40px);
}
}
Comment on lines +246 to +250
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment;

해당 코드가 왜 필요한가 하고 살펴보니 MenuTitle에서 마지막 요소를 제외하고 padding-right를 줘서 메뉴간 간격을 주고 있기 때문이네요.

  &:not(:last-child) {
    padding-right: 40px;
  }

not 선택자를 제거하고 MenuTitlepadding-right: 40px를 주면 해당 코드를 작성해주지 않아도 될 것 같아요.

그런데 요소간 간격을 줄 때 padding-right를 주기 보다는 display: flex가 지정되어 있으니 gap을 활용해도 좋을 것 같습니다.

`;

export const MenuTitle = styled.div<MenuTitleProps>`
Expand Down
6 changes: 3 additions & 3 deletions src/components/Header/menuTapList.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ export const menuTapList: MenuTapList = [
href: '/sponsor',
},
{
type: MenuTapType.Anchor,
title: '지원하기',
href: 'https://sopt-recruiting.web.app/recruiting/apply/ob',
type: MenuTapType.Router,
title: '리크루팅',
href: '/recruit',
},
];
Loading
Loading