-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SP0] Recruit 탭 추가 #157
Merged
Merged
[SP0] Recruit 탭 추가 #157
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
1834446
feat: add google sheet api
SeojinSeojin e1bebfa
feat: add process.env reader
SeojinSeojin 990ed04
feat : add Recruit Page UI
SeojinSeojin 42b002a
fix: project description's white-space
SeojinSeojin 7617c17
feat: recruit page 링크 변경
SeojinSeojin 4d4e9f7
fix color
SeojinSeojin 1dcf057
fix: fix styles
SeojinSeojin f291360
fix: fix UI
SeojinSeojin 18f117c
fix: apply design qa
SeojinSeojin 33909e3
fix: fix padding of chips
SeojinSeojin 5f21067
fix: fix uikit typo
SeojinSeojin a719eda
feat : 리크루팅 페이지 서버 자주 묻는 질문 내용 수정
f0rever0 d313cf2
Merge pull request #158 from sopt-makers/fix/project-pre-wrap
SeojinSeojin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment;
해당 코드가 왜 필요한가 하고 살펴보니
MenuTitle
에서 마지막 요소를 제외하고padding-right
를 줘서 메뉴간 간격을 주고 있기 때문이네요.not 선택자를 제거하고
MenuTitle
에padding-right: 40px
를 주면 해당 코드를 작성해주지 않아도 될 것 같아요.그런데 요소간 간격을 줄 때
padding-right
를 주기 보다는display: flex
가 지정되어 있으니gap
을 활용해도 좋을 것 같습니다.