출석 뷰 컴포즈로 마이그레이션(진행중) #990

giovannijunseokim · 2024-12-01T08:00:36Z

What is this issue?

[x]

Reference

[x]

height · 2024-12-01T08:00:38Z

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

l2hyunwoo

리뷰확인점

l2hyunwoo · 2024-12-03T01:40:52Z

app/build.gradle.kts

@@ -148,6 +148,7 @@ dependencies {
    implementation(libs.kotlin.coroutines.google.play)
    implementation(platform(libs.compose.bom))
    implementation(libs.bundles.compose)
+    implementation(libs.compose.lifecycle)


어라 이거 bundles.compose에 없었나..?

l2hyunwoo · 2024-12-03T01:41:10Z

app/src/main/java/org/sopt/official/feature/attendance/NewAttendanceActivity.kt

이거 머지 전에 AttendanceActivity로 변경 필요

l2hyunwoo · 2024-12-03T01:41:54Z

app/src/main/java/org/sopt/official/feature/attendance/compose/AttendanceRoute.kt

+                is AttendanceUiState.Failure -> {}
+                AttendanceUiState.NetworkError -> {}


이 부분에는 뭔가 Default 에러 화면...?

l2hyunwoo · 2024-12-03T01:42:33Z

app/src/main/java/org/sopt/official/feature/attendance/compose/AttendanceRoute.kt

+@Composable
+fun NewAttendanceViewModel.rememberAttendanceActions(): AttendanceAction = remember(this) {
+    AttendanceAction(
+        onFakeClick = {}
+    )
+}


멤버함수가 아닌 확장함수로 정의한 이유가 있을까유? 검색할 때 조금 어려울 것 같긴 한데

그리고 remember 키에 viewmodel 건 이유가 있는지 궁금합니당!

l2hyunwoo · 2024-12-03T01:44:12Z

app/src/main/java/org/sopt/official/feature/attendance/compose/AttendanceScreen.kt

+
+@Preview
+@Composable
+private fun AttendanceScreenPreview(@PreviewParameter(AttendanceScreenPreviewParameterProvider::class) parameter: AttendanceScreenPreviewParameter) {


Suggested change

private fun AttendanceScreenPreview(@PreviewParameter(AttendanceScreenPreviewParameterProvider::class) parameter: AttendanceScreenPreviewParameter) {

private fun AttendanceScreenPreview(

@PreviewParameter(AttendanceScreenPreviewParameterProvider::class)

parameter: AttendanceScreenPreviewParameter

) {

이렇게 적어도 괜찮을듯? 패러미터 클래스가 너무기네ㅋㅋ

l2hyunwoo · 2024-12-03T01:47:07Z

...c/main/java/org/sopt/official/feature/attendance/compose/component/AttendanceCodeCardList.kt

+
+@Composable
+fun AttendanceCodeCardList(
+    codes: List<String?>,


ImmtableList...?

l2hyunwoo · 2024-12-03T01:47:41Z

...src/main/java/org/sopt/official/feature/attendance/compose/component/AttendanceCodeDialog.kt

+                onTextChange = {},
+                onTextFieldFull = {},


이것도 아직 구현이 안된거죠?

l2hyunwoo · 2024-12-03T01:48:40Z

...rc/main/java/org/sopt/official/feature/attendance/compose/component/AttendanceHistoryCard.kt

+fun AttendanceHistoryCard(
+    userTitle: String,
+    attendanceScore: Int,
+    totalAttendanceResult: Map<AttendanceResultType, Int>,


Map도 ImmtableMap이나 PersistentMap 같은 것이 있을겁니당

l2hyunwoo · 2024-12-03T01:49:25Z

...java/org/sopt/official/feature/attendance/compose/component/AttendanceHistoryUserInfoCard.kt

+            Text(
+                text = "현재 출석점수는 ",
+                color = SoptTheme.colors.onSurface10,
+                style = SoptTheme.typography.body18M
+            )
+            Text(
+                text = "${attendanceScore}점",
+                color = Orange400,
+                style = SoptTheme.typography.title20SB
+            )
+            Text(
+                text = " 입니다!",
+                color = SoptTheme.colors.onSurface10,
+                style = SoptTheme.typography.body18M
+            )


이런건 buildAnnotatedString 같은걸로 구현 가능!

l2hyunwoo · 2024-12-03T01:50:15Z

...rc/main/java/org/sopt/official/feature/attendance/compose/component/AttendanceProgressBar.kt

+fun calculateAttendanceProgress(
+    firstAttendance: MidtermAttendance,
+    secondAttendance: MidtermAttendance,
+): Float {
+    if (!firstAttendance.isFinished) return 0f
+    if (!secondAttendance.isFinished) {
+        return 0.5f
+    } else {
+        return 1f
+    }
+}


이런거면 MidtermAttendance의 멤버함수 내부에서 정의가 가능하지 않을까요?

* feat: implement NewAttendanceActivity * feat: implement NewAttendanceViewModel * chore: add compose-lifecycle dependency * feat: define AttendanceAction * feat: implement screens * feat: use SoptTheme in designsystem * chore: data class -> class로 변경 * chore: 람다 프로퍼티 이름 명시 * chore: SoptTheme darkTheme 기본값 사용 * chore: 필요없는 함수 제거 * chore: 구현 안 된 함수에 TODO 삽입 * chore: 동작하지 않는 Preview 제거 * chore: AttendanceAction 내 뷰모델 참조 제거 * chore: code format 변경

* chore: core 모듈의 designsystem에 NoRippleClickable 추가 * feat: AttendanceTopAppBar 생성 * chore: String 리소스 추출 * chore: TODO : fetchData 구현 * chore: AttendanceTopAppBar 적용 * chore: Modifier 인자 추가 * chore: extract string resource * chore: change style and delete action class * chore: change icon * chore: delete NoRippleClickable * chore: use clickable

* chore: icon 리소스 추가 * feat: MidtermAttendanceCard 구현 * feat: FinalAttendanceCard 구현 * feat: AttendanceProgressBar 구현 * feat: AttendanceHistoryCard 구현 * chore: string 리소스 추출 * chore: rename * chore: change class name * chore: add text style * chore: add AttendanceHistoryCard radius * feat: implement TodayNoAttendanceCard * feat: implement TodayNoScheduleCard * chore: extract string resource * chore: separate model * chore: use PreviewParameter * chore: apply spotlessApply * chore: change class, objects in sealed to data class, data objects

* feat: AttendanceHistoryCard 구현 * chore: string 리소스 추출 * rebase * feat: AttendanceHistoryCard * feat: AttendanceHistorySummaryCard * feat: AttendanceHistoryUserInfoCard * chore: add dependency for collectAsStateWithLifecycle * chore: add text style to AttendanceHistoryUserInfoCard * feat: implement AttendanceHistoryUserInfoCard * feat: implement AttendanceHistorySummaryCard * feat: implement AttendanceCountCard * feat: implement AttendanceResultType * chore: move AttendanceHistoryCardState to model package * chore: move components to component package * feat: implement AttendanceHistoryCard * chore: change access modifier * feat: replace List with ImmutableList * chore: remove dependency

* Attendance screen compose setting (#676) * feat: implement NewAttendanceActivity * feat: implement NewAttendanceViewModel * chore: add compose-lifecycle dependency * feat: define AttendanceAction * feat: implement screens * feat: use SoptTheme in designsystem * chore: data class -> class로 변경 * chore: 람다 프로퍼티 이름 명시 * chore: SoptTheme darkTheme 기본값 사용 * chore: 필요없는 함수 제거 * chore: 구현 안 된 함수에 TODO 삽입 * chore: 동작하지 않는 Preview 제거 * chore: AttendanceAction 내 뷰모델 참조 제거 * chore: code format 변경 * chore: make stamp design system internal * chore: extract string resource * feat: implement AttendanceCodeCard * feat: implement AttendanceCodeCardList * chore: change logic * feat: implement AttendanceCodeDialog * feat: implement attendance button * chore: string resource 추출 * chore: change parameter List to ImmutableList * chore: reformat codee # Conflicts: # core/designsystem/src/main/java/org/sopt/official/designsystem/Color.kt

* chore: rename AttendanceType -> AttendanceSession * chore: delete state for components * chore: use immutable collection * chore: remove mock * feat: add AttendanceDayType.kt * feat: implement AttendanceScreen * feat: adjust layout * chore: move background setting to component * chore: merge state class into UiState class * chore: move package * chore: keep convention * chore: separate AttendanceGradientBox * chore: rename ProgressBarState to AttendanceProgressBarPreviewParameter * chore: keep convention

pull-request-size bot added the size/XXL label Dec 1, 2024

l2hyunwoo reviewed Dec 3, 2024

View reviewed changes

giovannijunseokim self-assigned this Dec 4, 2024

giovannijunseokim changed the title ~~Feature/refactor attendance screen~~ 출석 뷰 컴포즈로 마이그레이션(아직 진행중) Jan 2, 2025

giovannijunseokim changed the title ~~출석 뷰 컴포즈로 마이그레이션(아직 진행중)~~ 출석 뷰 컴포즈로 마이그레이션(진행중) Jan 3, 2025

giovannijunseokim added 6 commits January 4, 2025 20:50

giovannijunseokim force-pushed the feature/refactor-attendance-screen branch from b43f21c to d2b9c0d Compare January 4, 2025 11:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

출석 뷰 컴포즈로 마이그레이션(진행중) #990

출석 뷰 컴포즈로 마이그레이션(진행중) #990

giovannijunseokim commented Dec 1, 2024

height bot commented Dec 1, 2024

l2hyunwoo left a comment

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

l2hyunwoo Dec 3, 2024

		is AttendanceUiState.Failure -> {}
		AttendanceUiState.NetworkError -> {}

출석 뷰 컴포즈로 마이그레이션(진행중) #990

Are you sure you want to change the base?

출석 뷰 컴포즈로 마이그레이션(진행중) #990

Conversation

giovannijunseokim commented Dec 1, 2024

What is this issue?

Reference

height bot commented Dec 1, 2024

l2hyunwoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment