-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix/#871] 마이페이지 오류 수정 #907
Changes from all commits
b91142f
661e1b5
44b6727
ec9c02d
749226f
f6a3495
9d9b32c
6270326
9eec6da
70f077e
eb25798
7194eff
2afdbfc
a994e4b
880fb19
eea9cc4
adf5d5b
fdfaf0b
b12835f
9b6b873
c487625
7746918
2f50399
8dc7cac
8bac4ac
abd79f9
f8d30f3
482e355
8fd8527
6083cb9
e22c296
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,8 +54,8 @@ class AuthRepositoryImpl @Inject constructor( | |
remoteAuthDataSource.withdraw() | ||
} | ||
|
||
override suspend fun logout(pushToken: String): Result<Unit> = runCatching { | ||
remoteAuthDataSource.logout( | ||
override suspend fun logout(pushToken: String) = runCatching { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 토큰은 로컬 저장소에 저장 및 관리되고 있고 로그아웃은 무조건 본인의 토큰만을 보낼 것 같은데 파라미터로 받는 이유가 있으신가요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. pushToken을 파라미터로 받을 이유가 없다는 말씀이신가요..?! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 아하 저도 실제 사용처 찾아보니 파이어베이스 토큰을 호출해서 넣어주고 있었네요. |
||
remoteAuthDataSource.deleteUserInfo( | ||
LogOutRequest( | ||
platform = "Android", | ||
pushToken = pushToken | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 그냥 궁금한건데 Delete 어노테이션과 차이가 있나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete에 body 값이 안들어가는게 원칙인데 굳이 넣어줘야할 때에는 이렇게 사용하는걸로 알고 있음
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
저거 무시하고 그냥 body 패러미터 넣으면 에러 일으킴ㅋㅋㅋ
그래서 원칙적으로는
인데 난 갠적으로 1로 쇼부치는게 더 깔끔하다고 생각하긴함. (정 안되면 2번)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오.. 신기하네 하나 알아갑니다. 저도 같은이유라면 서버에게 요청하고 안되면 뭐 2번해야쥬