[Feature/#978] 홈 화면 개편(1) - 출석 및 바로가기 탭 구현 #1031
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
Reference
To Reviewer
안녕하세요 오랜만입니다...
이게 참... 상태가... 말도안되게 많습니다... 분기처리랑...
진짜 피알 최대한 작게 여러번 작업하려고 위에 바로가기탭까지만 작업했는데도 이모양이네요...
Compound Component Pattern 지난번에 듣고 괜찮아보여서 적용해보려했는데, 그땐 이해를 잘못했었나봐요
굳이 지금 제 코드에 필요해보이지 않아서 다시 뺐습니다.
테스트도 짜려했는데.. 시간관계상 나중에 추가해보도록 하겠습니다 ㅎㅎ..