Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

출석 정보 가져오기 구현 #1015

Open
wants to merge 17 commits into
base: feature/refactor-attendance-screen
Choose a base branch
from
Open

출석 정보 가져오기 구현 #1015

wants to merge 17 commits into from
+585 −32

Conversation

giovannijunseokim
Copy link
Contributor

@giovannijunseokim giovannijunseokim commented Jan 4, 2025 •
edited
Loading

What is this issue?

출석 정보를 가져오는 API를 연결하고 도메인으로 전환, Ui에 반영까지 작업하였습니다.

Image

추후 세션을 만들어서 테스트 해보고 수정 필요하면 수정해서 다시 올리겠슴다

Reference

  • [x]

@giovannijunseokim
AttendanceCodeDialog 구현 (#852)
afb8bd4 
* Attendance screen compose setting (#676)

* feat: implement NewAttendanceActivity

* feat: implement NewAttendanceViewModel

* chore: add compose-lifecycle dependency

* feat: define AttendanceAction

* feat: implement screens

* feat: use SoptTheme in designsystem

* chore: data class -> class로 변경

* chore: 람다 프로퍼티 이름 명시

* chore: SoptTheme darkTheme 기본값 사용

* chore: 필요없는 함수 제거

* chore: 구현 안 된 함수에 TODO 삽입

* chore: 동작하지 않는 Preview 제거

* chore: AttendanceAction 내 뷰모델 참조 제거

* chore: code format 변경

* chore: make stamp design system internal

* chore: extract string resource

* feat: implement AttendanceCodeCard

* feat: implement AttendanceCodeCardList

* chore: change logic

* feat: implement AttendanceCodeDialog

* feat: implement attendance button

* chore: string resource 추출

* chore: change parameter List to ImmutableList

* chore: reformat codee
@giovannijunseokim
feat: implement domain models
4ecaa50
@giovannijunseokim
feat: implement Repository
6b945d8
@giovannijunseokim
chore: remove unnecessary code
150abf8
@giovannijunseokim
chore: change attendanceScore to Float
15215fd
@giovannijunseokim
chore: reflect type name changed
5570654
@giovannijunseokim
chore: remove totalCount from parameters
76ab7e4
@giovannijunseokim
feat: add action onClickRefresh
e64c243
@giovannijunseokim
feat: implement bindDefaultAttendanceRepository
3b859b9
@giovannijunseokim
chore: add background at route
8b11eb9
@giovannijunseokim
chore: change button radius
cfbce73
@giovannijunseokim
chore: reformat code
0745e48
@giovannijunseokim
feat: implement Domain Model to UiModel
85ba59c
@giovannijunseokim giovannijunseokim requested a review from a team as a code owner January 4, 2025 16:16
@height Height
Copy link

height bot commented Jan 4, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@giovannijunseokim giovannijunseokim changed the title 출석 정보 가져오기 출석 정보 가져오기 구현 Jan 4, 2025
l2hyunwoo
l2hyunwoo reviewed Jan 5, 2025
View reviewed changes
app/src/main/java/org/sopt/official/domain/entity/attendance/AttendanceInfo.kt Outdated

import java.time.LocalDateTime

data class AttendanceInfo(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
data class AttendanceInfo(
data class Attendance(

로 줄이는건 어떨까요? Info는 불필요한 단어인 것 같아서요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅈ합니다. 감사합니다!

Copy link
Contributor Author

@giovannijunseokim giovannijunseokim Jan 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이름 변경했습니다! 839f758
추가적으로 SessionInfo도 Session으로 변경했습니다! 12b0a97

l2hyunwoo
l2hyunwoo reviewed Jan 5, 2025
View reviewed changes
app/src/main/java/org/sopt/official/feature/attendance/NewAttendanceViewModel.kt Outdated
is AttendanceInfo.AttendanceDayType.NoAttendance -> {
val sessionInfo = attendanceInfo.attendanceDayType.sessionInfo
AttendanceDayType.Event(
eventDate = "${sessionInfo.sessionStartTime} - ${sessionInfo.sessionEndTime}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LocalDateTime.parse로 파싱한걸 그대로 string으로 변환되면 2025-01-01T00:00:000 이런식으로 출력될 것 같은데, 혹시 어떻게 출력되는지 알 수 있을까요?

Copy link
Contributor Author

@giovannijunseokim giovannijunseokim Jan 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 부분 까먹고있다가 확인해서 작업했습니다! a1d1134 -> bac1a01
Kotlin Playground에서 테스트 해봤고, 잘 동작하는 것 같아요 ~!

l2hyunwoo
l2hyunwoo reviewed Jan 5, 2025
View reviewed changes
app/src/main/java/org/sopt/official/data/repository/attendance/DefaultAttendanceRepository.kt
Comment on lines +59 to +60
val firstAttendanceResponse: SoptEventResponse.AttendanceResponse? = soptEventResponse.attendances.firstOrNull()
val secondAttendanceResponse: SoptEventResponse.AttendanceResponse? = soptEventResponse.attendances.lastOrNull()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 lastOrNull로 가도 괜찮을까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예시 보니깐 attendances를 반드시 2개로 주긴 하더라구요. 더 좋은 방법이 있는지 생각해보겠습니다. 감사합니다!

l2hyunwoo
l2hyunwoo approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한번 확인해주시고 문제 없으면 바로 머지 갑시다 👍🏻 고생했어요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2hyunwoo l2hyunwoo l2hyunwoo approved these changes

Assignees

@giovannijunseokim giovannijunseokim

Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giovannijunseokim @l2hyunwoo