Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/#1009] AmplitudeTracker 추상화하여 Preview에 Fake 넣을 수 있게 수정 #1010

Merged
merged 7 commits into from
Jan 2, 2025
Merged

[feature/#1009] AmplitudeTracker 추상화하여 Preview에 Fake 넣을 수 있게 수정 #1010

merged 7 commits into from
Jan 2, 2025

Conversation

l2hyunwoo
Copy link
Member

@l2hyunwoo l2hyunwoo commented Dec 26, 2024 •
edited
Loading

What is this issue?

  • Preview에 CompositionLocal로 AmplitudeTracker 구현체를 직접 넣어줘야 했는데, Tracker로 추상화하여 Preview에는 Fake 넣을 수 있게 수정한다
스크린샷 2024-12-26 오후 7 30 33

@l2hyunwoo l2hyunwoo self-assigned this Dec 26, 2024
@l2hyunwoo l2hyunwoo requested a review from a team as a code owner December 26, 2024 10:29
@height Height
Copy link

height bot commented Dec 26, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

giovannijunseokim
giovannijunseokim approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@giovannijunseokim giovannijunseokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생하셨습니다 ~!

@l2hyunwoo l2hyunwoo linked an issue Jan 2, 2025 that may be closed by this pull request
[FIX] AmplitudeTracker 때문에 Compose Preview 안보이는 현상 해소 #1009
Closed
@l2hyunwoo l2hyunwoo merged commit 35b3dc9 into develop Jan 2, 2025
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/#1009 branch January 2, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannijunseokim giovannijunseokim giovannijunseokim approved these changes

Assignees

@l2hyunwoo l2hyunwoo

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIX] AmplitudeTracker 때문에 Compose Preview 안보이는 현상 해소
2 participants
@l2hyunwoo @giovannijunseokim