refactor: replace react-scripts (cra) with vite, and make necessary changes #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianvitterso
force-pushed
the
refactor/replace-react-scripts
branch
from
7a03c20 to
d259412
Compare
| @@ -10,7 +10,7 @@ const authConfig: TInternalConfig = { | |||
| clientId: 'myClientID', | |||
| authorizationEndpoint: 'myAuthEndpoint', | |||
| tokenEndpoint: 'myTokenEndpoint', | |||
| redirectUri: 'http://localhost:3000/', | |||
| redirectUri: 'http://localhost:5173/', | |||
There was a problem hiding this comment.
Not sure if I needed to change this one.
sebastianvitterso
force-pushed
the
refactor/replace-react-scripts
branch
from
d259412 to
531aa74
Compare
|
Seems to work! 🎉 |
soofstad
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change, and why?
Create React App (CRA) isn't as modern anymore, and using vite is (in my opinion) a cleaner choice.
Also we've made the switch in most of our other projects, so it's about time we do it here too.
Doesn't really matter though, since we're switching only for the example project, just thought it would be nice.
Issues related to this change
None