Popup window to be centred on screen #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianvitterso
requested changes
Oct 25, 2024
This comment was marked as outdated.
This comment was marked as outdated.
sebastianvitterso
force-pushed
the
popup-centred
branch
from
11f5a16 to
61851f3
Compare
sebastianvitterso
force-pushed
the
popup-centred
branch
from
61851f3 to
8fee446
Compare
soofstad
approved these changes
Nov 5, 2024
There was a problem hiding this comment.
Looks good! Tested OK.
Thank you for the contribution @thejurassic 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request change?
Popup window to be centred in the window (or screen)
Why is this pull request needed?
Popup window is not centred, and would provide better user experience if centred on the page theyre working on that invoked the login
Issues related to this change
None