-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DONOTMERGE][7.1.r1] Cleanup of all configs #96
base: aosp/LA.UM.7.1.r1
Are you sure you want to change the base?
[DONOTMERGE][7.1.r1] Cleanup of all configs #96
Conversation
This SoC does not feature PCI. Disable it.
We don't need these. Definitely not in *base*_sm6125.
SONY sm6125 devices ships with eMMC.
These SoCs are not supported on the 4.14 kernel.
Most of the options were common among all of the SoCs. Put these into a msm-common.config file and add it to update-defconfig.sh.
a3f8b68
to
323af8c
Compare
@konradybcio You force-pushed the merge of all dupes in Anyway, afaik the intent is to rename |
I forcepushed the branch to fix indentation.
I mean, the name is not really important in this case, I can settle for anything that works. (this might appear twice, turns out email&gh don't really go along too well..) |
The force-push diff link shows the changes have been reverted/removed entirely: https://github.com/sonyxperiadev/kernel-defconfig/compare/a3f8b68fcdf10609216329e28adddcd40f5fe755..323af8cce4efbb0e08d1455a888aacd3d6c494e5
Not just about the name, but that file already exists - no need to create another one if it serves an identical purpose, don't want to run into the situation where it is unclear what config should end up in which file. |
Right, my branch marker went to HEAD~2, hopefully fixed now. |
Why do we duplicate so much stuff in every config? Let's put it all in
msm-common.config
and add it to defconfig_update.sh. Also, while at it, remove Loire and Tone configs, as these platforms are not supported on 4.14.This assumes #95 is merged.