Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONOTMERGE][7.1.r1] Cleanup of all configs #96

Draft
wants to merge 14 commits into
base: aosp/LA.UM.7.1.r1
Choose a base branch
from

Conversation

konradybcio
Copy link
Contributor

Why do we duplicate so much stuff in every config? Let's put it all in msm-common.config and add it to defconfig_update.sh. Also, while at it, remove Loire and Tone configs, as these platforms are not supported on 4.14.

This assumes #95 is merged.

@konradybcio konradybcio marked this pull request as draft February 15, 2021 18:12
update_defconfig.sh Outdated Show resolved Hide resolved
Most of the options were common among all of the SoCs. Put these
into a msm-common.config file and add it to update-defconfig.sh.
@MarijnS95
Copy link
Contributor

@konradybcio You force-pushed the merge of all dupes in msm-common.config off again?

Anyway, afaik the intent is to rename android-extra.config for this instead, which is not provided by AOSP and literally used as common base for all SODP devices. If you want we could have an msm-common for SoC generic stuff, and sodp-common for... sodp generic stuff.

@konradybcio
Copy link
Contributor Author

You force-pushed the merge of all dupes in msm-common.config off again?

I forcepushed the branch to fix indentation.

Anyway, afaik the intent is to rename android-extra.config for this instead, which is not provided by AOSP and literally used as common base for all SODP devices. If you want we could have an msm-common for SoC generic stuff, and sodp-common for... sodp generic stuff.

I mean, the name is not really important in this case, I can settle for anything that works.

(this might appear twice, turns out email&gh don't really go along too well..)

@MarijnS95
Copy link
Contributor

You force-pushed the merge of all dupes in msm-common.config off again?

I forcepushed the branch to fix indentation.

The force-push diff link shows the changes have been reverted/removed entirely: https://github.com/sonyxperiadev/kernel-defconfig/compare/a3f8b68fcdf10609216329e28adddcd40f5fe755..323af8cce4efbb0e08d1455a888aacd3d6c494e5

I mean, the name is not really important in this case, I can settle for anything that works.

Not just about the name, but that file already exists - no need to create another one if it serves an identical purpose, don't want to run into the situation where it is unclear what config should end up in which file.

@konradybcio
Copy link
Contributor Author

Right, my branch marker went to HEAD~2, hopefully fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants