-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kdump enhancement for remote ssh, cli subcommands added. #3317
Open
bilal-ismail
wants to merge
49
commits into
sonic-net:master
Choose a base branch
from
bilal-ismail:kdump_cli_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An update for the current fork to keep working on latest codebase for the use of kdump remote usecase.
…ies-forked into kdump_cli_updates updateing the branch with master
…ies-forked into kdump_cli_updates updating the branch with latest comits to the repo
…ate>=0.8.2,<=0.9.0". For resolving conflict with sonic-yang-mgmt 1.0 dependency of tabulate.
… commands properly.
…onic-utilities-forked into kdump_cli_updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Worked on the enhancement of kdump utility for sonic. Added two new subcommands along with two options i.e
1- sudo config kdump remote ssh --conn-str ___ --key-path ___
2- sudo config kdump remote disable
How I did it
Made changes to 3 files in total,
1- config/kdump (added two new subcommands and options for modentry to config_db)
2- show/kdump (cli command to print running config)
3- scripts/sonic-kdump-config (scripts or ready methods for usage upon load and unload of kdump module)
How to verify it
upon loading this utilities' build to the running sonic image we can try and test these commands for verifying it's behavior as per the requirements.