Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front panel port name regex #2127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itamar-talmon
Copy link

@itamar-talmon itamar-talmon commented Apr 5, 2022

What I did
Removed the dependency on the "Ethernet" string in the SONiC code base and added support
for extending the front panel port name pattern.

How I did it

Introduced FRONT_PANEL_PORT_PREFIX_REGEX that extends the old FRONT_PANEL_PORT_PREFIX ("Ethernet")
Updated all the relevant usage of the "Ethernet" throughout the code base to use the new regex pattern
How to verify it
Pass all UT and CI testing.

Why I did it
In order to support distinguishing between different types of front panel ports in a maintainable fashion.
Specifically, we are planning to bring up a system with 'service' ports (in addition to the regular ethernet data ports) - these
are lower speed ports that used for connection to accelerators, internal loopbacks and more.

- Related Commits and Merge Strategy
This is part of a group of related commits and should be merged after sonic-net/sonic-swss-common#598 and sonic-net/sonic-buildimage#10471 and sonic-net/sonic-py-swsssdk#121.

The full merge order is:

  1. swss-common - Added front panel port prefix regex to schema.h sonic-swss-common#598
  2. sonic-buildimage - Added support for front panel port prefix regex sonic-buildimage#10471
  3. swsssdk - Added support for front panel port prefix regex sonic-py-swsssdk#121
  4. all the rest
    https://github.com/Azure/sonic-utilities/pull/2127
    https://github.com/Azure/sonic-snmpagent/pull/251
    https://github.com/Azure/sonic-swss/pull/2223
    https://github.com/Azure/sonic-platform-daemons/pull/252
    https://github.com/Azure/sonic-platform-common/pull/274

@itamar-talmon
Copy link
Author

This PR depends on sonic-net/sonic-swss-common#598 so it will not pass until it merged

pfc/main.py Outdated Show resolved Hide resolved
@itamar-talmon itamar-talmon force-pushed the front_panel_port_name_regex branch 2 times, most recently from 3609215 to 17d5929 Compare June 1, 2022 11:31
@itamar-talmon
Copy link
Author

@kcudnik @qiluo-msft - could you please check it out after my update?
Checks will fail until related commits will be merged (in the description).
Thank you!

qiluo-msft
qiluo-msft previously approved these changes Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants