[dash] Add outbound Privatelink traffic test #14757

theasianpianist · 2024-09-26T06:38:26Z

Description of PR

Summary:
Fixes #14613

Type of change

Bug fix
Testbed and Framework(new/improvement)
Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Smartswitch testbed only

Documentation

Signed-off-by: Prabhat Aravind <[email protected]>

Signed-off-by: Lawrence Lee <[email protected]>

prsunny · 2024-09-26T16:53:57Z

@mukeshmv to review

oleksandrivantsiv · 2024-09-26T20:05:55Z

tests/dash/test_dash_privatelink.py

+
+@pytest.fixture(scope="module")
+def dpu_ip(duthost, dpu_index):
+    cmd = f"ip addr show | grep Ethernet-BP{dpu_index} | grep inet | awk '{{print $2}}'"


The interface is vendor-specific. It should be taken from platform.json file: https://github.com/sonic-net/SONiC/blob/master/doc/smart-switch/pmon/smartswitch-pmon.md#313-npu-to-dpu-data-port-mapping

Here is an example of Nvidia platform:
sonic-net/sonic-buildimage#20358

Signed-off-by: Lawrence Lee <[email protected]>

JibinBao

Can we have a test plan to explain the test? espeicallly for the privatelink_config,
What do the variables defined in the file of privatelink_config.py mean? If there is a chart to introduce the different ips in the test, it will be better.
Thanks

JibinBao · 2024-10-08T07:02:46Z

tests/dash/packets.py

+    return str(ip_address(overlay_dip))
+
+
+def outbound_pl_packets(config, inner_packet_type='udp', vxlan_udp_dport=4789):


Do we have scenarios for inbound_pl_packets?

JibinBao · 2024-10-08T07:17:54Z

tests/dash/test_dash_privatelink.py

+
+    yield
+
+    duthost.shell(f"ip route del {pl.SIP}")


Before yield, it uses replace to change the static route, which means that a route related to pl.sip may exist. So, if we use del to remove the pl.sip route, it seems that it cannot restore to the original route status. Right?

JibinBao · 2024-10-08T07:29:17Z

tests/dash/test_dash_vnet.py

@@ -65,7 +65,7 @@ def test_outbound_direct(
        inner_packet_type,
        acl_default_rule,
        vxlan_udp_dport):
-    asic_db_checker(["SAI_OBJECT_TYPE_VNET", "SAI_OBJECT_TYPE_ENI"])
+    # asic_db_checker(["SAI_OBJECT_TYPE_VNET", "SAI_OBJECT_TYPE_ENI"])


why remove the line?

JibinBao · 2024-10-08T07:37:49Z

tests/dash/configs/privatelink_config.py

+PL_ENCODING_IP = "::56b2:0:ff71:0:0"
+PL_ENCODING_MASK = "::ffff:ffff:ffff:0:0"
+PL_UNDERLAY_SIP1 = "55.1.2.3"
+PL_UNDERLAY_SIP2 = "55.2.3.4"


It seems that we don't use it

JibinBao · 2024-10-08T07:38:03Z

tests/dash/configs/privatelink_config.py

+INBOUND_UNDERLAY_IP = "25.1.1.1"
+OUTBOUND_UNDERLAY_IP = "101.1.2.3"
+VNET_MAP_IP1 = "10.1.1.5"
+VNET_MAP_IP2 = "10.1.2.5"


It seems that we don't use it

oleksandrivantsiv · 2024-10-09T00:04:19Z

tests/dash/packets.py

+        ip_dst=pl.SIP,
+        udp_dport=vxlan_udp_dport,
+        with_udp_chksum=False,
+        vxlan_vni=int(pl.VNET1_VNI),


This is outbound packet. VNI should be set to VM_VNI

JibinBao · 2024-10-09T01:51:09Z

tests/dash/packets.py

+    inner_packet = generate_inner_packet(inner_packet_type)(
+        eth_src=pl.ENI_MAC,
+        ip_src=config[LOCAL_CA_IP],
+        ip_dst=pl.VNET_MAP_IP1,


p1.VNET_MAP_IP1 is PE (private endpoint). Right?

oleksandrivantsiv · 2024-10-09T20:47:14Z

@theasianpianist the test misses the data plane interface configuration for both the NPU and DPU sides. There is a static route that the test adds on the NPU side to send traffic to the DPU, but no IP address configuration on the interfaces. Therefore, the test won’t work without some manual pre-configuration. My assumption is that the test should be atomic and apply the full configuration needed to pass. The test should be extended to set the IP address on the NPU, and the IP address and VIP address on the DPU.

oleksandrivantsiv

As commented

oleksandrivantsiv · 2024-10-09T22:04:13Z

tests/dash/configs/privatelink_config.py

+
+VNET_MAPPING_CONFIG = {
+    f"DASH_VNET_MAPPING_TABLE:{VNET1}:{VNET_MAP_IP1}": {
+        "mac_address": REMOTE_MAC_STRING,


This attribute is not suppored by the PL features:
sonic-net/sonic-swss#3319
Instead of setting this attribute as a part of the configuration, the test should use REMOTE_MAC as a destination inner MAC in the original VXLAN packet sent by PTF

oleksandrivantsiv · 2024-10-09T22:04:42Z

tests/dash/packets.py

+
+def outbound_pl_packets(config, inner_packet_type='udp', vxlan_udp_dport=4789):
+    inner_packet = generate_inner_packet(inner_packet_type)(
+        eth_src=pl.ENI_MAC,


The eth_dst should be set to the actual destination MAC address:

eth_dst=pl.REMOTE_MAC,

congh-nvidia · 2024-10-11T02:17:09Z

tests/dash/gnmi_utils.py

+    ptfhost,
+    messages,
+    dpu_index,
+    set=True,


'set' is a Python built-in name, better to use another name.

congh-nvidia · 2024-10-15T07:48:07Z

tests/dash/gnmi_utils.py

+                file.write(message.SerializeToString())
+            update_list.append(path)
+        else:
+            path = f"/APPL_DB/dpu{dpu_index}/{filename}"


should be gnmi_key instead of filename

congh-nvidia · 2024-10-16T02:52:47Z

tests/dash/test_dash_privatelink.py

+    logger.info(messages)
+    apply_messages(localhost, duthost, ptfhost, messages, dpu_index)
+
+    return


There is no clean up of the dash configurations.

StormLiangMS · 2024-10-21T05:41:39Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-10-21T05:41:48Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS · 2024-10-30T01:57:41Z

/azp run Azure.sonic-mgmt

azure-pipelines · 2024-10-30T01:57:51Z

Azure Pipelines successfully started running 1 pipeline(s).

oleksandrivantsiv · 2024-10-30T18:31:13Z

tests/dash/packets.py

+        gre_key=pl.ENCAP_VNI << 8,
+        inner_frame=exp_inner_packet,
+        ip_id=0,
+        ip_ttl=63,


Expected TTL should be changed to 254 based on sonic-net/DASH#636 PR

oleksandrivantsiv · 2024-11-01T02:31:24Z

tests/dash/configs/privatelink_config.py

+        "mac_address": ENI_MAC,
+        "eni_id": ENI_ID,
+        "admin_state": State.STATE_ENABLED,
+        "pl_underlay_sip": PL_UNDERLAY_SIP1,


pl_underlay_sip in the ENI table should be equal to the SIP address.

aronovic · 2024-11-21T14:47:46Z

tests/dash/gnmi_utils.py

+            if proto_utils.ENABLE_PROTO:
+                path = f"/APPL_DB/dpu{dpu_index}/{gnmi_key}:$/root/{filename}"
+            else:
+                path = f"/APPL_DB/dpu{dpu_index}/{gnmi_key}:@/root/{filename}"


For the path assignment, the else seems to be the same as the if.

aronovic · 2024-11-21T14:50:39Z

tests/dash/gnmi_utils.py

                else:
-                    path = "/APPL_DB/localhost/%s:@/root/%s" % (k, filename)
+                    path = "/APPL_DB/dpu1/%s:@/root/%s" % (k, filename)


Is this test only for DPU1?

prabhataravind and others added 3 commits September 26, 2024 06:33

[dash]: Initial changes to run dash tests on smartswitch

2831abe

Signed-off-by: Prabhat Aravind <[email protected]>

Add privatelink configs

ee6190d

Signed-off-by: Lawrence Lee <[email protected]>

Add privatelink outbound test

52870fd

Signed-off-by: Lawrence Lee <[email protected]>

prsunny requested review from prabhataravind and oleksandrivantsiv September 26, 2024 16:52

oleksandrivantsiv reviewed Sep 26, 2024

View reviewed changes

theasianpianist added 2 commits September 28, 2024 01:55

improve config formatting

c9fdb12

Signed-off-by: Lawrence Lee <[email protected]>

remove unused config

dd59d33

Signed-off-by: Lawrence Lee <[email protected]>

JibinBao reviewed Oct 8, 2024

View reviewed changes

oleksandrivantsiv reviewed Oct 9, 2024

View reviewed changes

JibinBao reviewed Oct 9, 2024

View reviewed changes

mukeshmv approved these changes Oct 9, 2024

View reviewed changes

oleksandrivantsiv suggested changes Oct 9, 2024

View reviewed changes

oleksandrivantsiv reviewed Oct 9, 2024

View reviewed changes

congh-nvidia reviewed Oct 11, 2024

View reviewed changes

congh-nvidia reviewed Oct 15, 2024

View reviewed changes

congh-nvidia reviewed Oct 16, 2024

View reviewed changes

oleksandrivantsiv reviewed Oct 30, 2024

View reviewed changes

oleksandrivantsiv reviewed Nov 1, 2024

View reviewed changes

aronovic reviewed Nov 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dash] Add outbound Privatelink traffic test #14757

[dash] Add outbound Privatelink traffic test #14757

theasianpianist commented Sep 26, 2024

prsunny commented Sep 26, 2024

oleksandrivantsiv Sep 26, 2024

oleksandrivantsiv Sep 26, 2024

JibinBao left a comment

JibinBao Oct 8, 2024

JibinBao Oct 8, 2024

JibinBao Oct 8, 2024

JibinBao Oct 8, 2024

JibinBao Oct 8, 2024

oleksandrivantsiv Oct 9, 2024

JibinBao Oct 9, 2024

oleksandrivantsiv commented Oct 9, 2024

oleksandrivantsiv left a comment

oleksandrivantsiv Oct 9, 2024

oleksandrivantsiv Oct 9, 2024

congh-nvidia Oct 11, 2024

congh-nvidia Oct 15, 2024

congh-nvidia Oct 16, 2024

StormLiangMS commented Oct 21, 2024

azure-pipelines bot commented Oct 21, 2024

StormLiangMS commented Oct 30, 2024

azure-pipelines bot commented Oct 30, 2024

oleksandrivantsiv Oct 30, 2024

oleksandrivantsiv Nov 1, 2024

aronovic Nov 21, 2024 •

edited

Loading

aronovic Nov 21, 2024

		return str(ip_address(overlay_dip))


		def outbound_pl_packets(config, inner_packet_type='udp', vxlan_udp_dport=4789):

[dash] Add outbound Privatelink traffic test #14757

Are you sure you want to change the base?

[dash] Add outbound Privatelink traffic test #14757

Conversation

theasianpianist commented Sep 26, 2024

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

prsunny commented Sep 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JibinBao left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oleksandrivantsiv commented Oct 9, 2024

oleksandrivantsiv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

StormLiangMS commented Oct 21, 2024

azure-pipelines bot commented Oct 21, 2024

StormLiangMS commented Oct 30, 2024

azure-pipelines bot commented Oct 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aronovic Nov 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aronovic Nov 21, 2024 •

edited

Loading