Simplify swbus-edge api #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not previously realize swbus-edge was going to be used for infra stuff like sending traceroutes. So, this pr is not good as-is. Maybe I will make a 'SimpleSwbusEdgeRuntime' or 'ApplicationSwbusEdgeRuntime' that will have this interface, and leave the original, fully-fledged SwbusEdgeRuntime alone. |
r12f
reviewed
Nov 21, 2024
r12f
reviewed
Nov 21, 2024
erer1243
force-pushed
the
swbus-edge-simplify
branch
from
8089bc1
to
4fdbdcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please tell me your thoughts on only exposing (Route)DataRequest and Response messages to SwbusEdge clients. I also renamed RouteDataRequest to DataRequest (better name? I found "RouteDataRequest" confusing because I thought it meant "a request for data about routes") and epoch to id.