-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpers for fetching ConfigDB entries on multi-asic #17243
Conversation
@vmittal-msft @arlakshm please review |
3ea6f19
to
59b57b8
Compare
@vmittal-msft have you test this change against single asic / T0 / T1 boxes? |
@yxieca these changes are not needed for 202205 or 202305. These changes will go in 202405, Please help merge the changes in master |
@vmittal-msft @arlakshm this question is irrelevant with back porting, I just want to know if this change is single-asic safe? |
@bktsim-arista please also help confirm if this is tested for single-asic, thanks |
@yxieca and @rlhui I can confirm that these changes have been tested on single ASIC platforms against the |
@bktsim-arista Please raise a PR to 202405 to address conflict. |
Why I did it
This change adds generic functions that can be used to fetch tables from ConfigDB for multi-asic devices based on previous functions created for fetching PORT tables. These functions are to be used in upcoming changes for adding multi-asic support for show/config commands for #15148 to prevent duplicate code.
How I did it
Modified previously existing helper functions for fetching ports in multi-asic devices and made then generic.
Description for the changelog
Added generic helper functions for fetching ConfigDB entries for multi-asic devices.