Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helpers for fetching ConfigDB entries on multi-asic #17243

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

bktsim-arista
Copy link
Contributor

@bktsim-arista bktsim-arista commented Nov 20, 2023

Why I did it

This change adds generic functions that can be used to fetch tables from ConfigDB for multi-asic devices based on previous functions created for fetching PORT tables. These functions are to be used in upcoming changes for adding multi-asic support for show/config commands for #15148 to prevent duplicate code.

How I did it

Modified previously existing helper functions for fetching ports in multi-asic devices and made then generic.

Description for the changelog

Added generic helper functions for fetching ConfigDB entries for multi-asic devices.

@bktsim-arista bktsim-arista changed the title Add helpers for fetching entries on multi-asic Add helpers for fetching ConfigDB entries on multi-asic Nov 20, 2023
@kenneth-arista
Copy link
Contributor

kenneth-arista commented Nov 29, 2023

@vmittal-msft @arlakshm please review

@vmittal-msft
Copy link
Contributor

@yxieca @wangxin please help merge

@yxieca
Copy link
Contributor

yxieca commented Mar 26, 2024

@yxieca @wangxin please help merge

@vmittal-msft have you test this change against single asic / T0 / T1 boxes?

@arlakshm
Copy link
Contributor

@yxieca @wangxin please help merge

@vmittal-msft have you test this change against single asic / T0 / T1 boxes?

@yxieca these changes are not needed for 202205 or 202305. These changes will go in 202405, Please help merge the changes in master

@yxieca
Copy link
Contributor

yxieca commented Apr 1, 2024

@yxieca @wangxin please help merge

@vmittal-msft have you test this change against single asic / T0 / T1 boxes?

@yxieca these changes are not needed for 202205 or 202305. These changes will go in 202405, Please help merge the changes in master

@vmittal-msft @arlakshm this question is irrelevant with back porting, I just want to know if this change is single-asic safe?

@rlhui
Copy link
Contributor

rlhui commented Apr 8, 2024

@bktsim-arista please also help confirm if this is tested for single-asic, thanks

@kenneth-arista
Copy link
Contributor

@yxieca and @rlhui I can confirm that these changes have been tested on single ASIC platforms against the master branch. Specifically, multi_asic.get_port_table() is used implementing show interfaces alias (see https://github.com/sonic-net/sonic-utilities/blob/master/show/interfaces/__init__.py#L67). We have executed sonic-mgmt/test_iface_namingmode.py tests against m0, t0, and t1 topologies successfully with these changes.

@yxieca yxieca merged commit c7cd477 into sonic-net:master Apr 9, 2024
19 checks passed
@bingwang-ms
Copy link
Contributor

@bktsim-arista Please raise a PR to 202405 to address conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants