代码优化

songxinjianqwe · Aug 24, 2018 · 4c051b8 · 4c051b8
1 parent fb919f0
commit 4c051b8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/toy-rpc-core/src/main/java/com/sinjinsong/toy/common/context/RPCThreadLocalContext.java b/toy-rpc-core/src/main/java/com/sinjinsong/toy/common/context/RPCThreadLocalContext.java
@@ -9,7 +9,7 @@
  * @date 2018/6/10
  * 线程私有！
  */
-public class RPCThreadLocalContext<T> {
+public class RPCThreadLocalContext {
     private static final ThreadLocal<RPCThreadLocalContext> RPC_CONTEXT = new ThreadLocal() {
         @Override
         protected Object initialValue() {
@@ -20,15 +20,15 @@ protected Object initialValue() {
     private RPCThreadLocalContext() {
     }
 
-    private Future<T> future;
+    private Future future;
     private Invoker invoker;
 
 
     public static RPCThreadLocalContext getContext() {
         return RPC_CONTEXT.get();
     }
 
-    public Future<T> getFuture() {
+    public Future getFuture() {
         return future;
     }
 
@@ -40,7 +40,7 @@ public void setInvoker(Invoker invoker) {
         this.invoker = invoker;
     }
 
-    public void setFuture(Future<T> future) {
+    public void setFuture(Future future) {
         this.future = future;
     }
 

diff --git a/toy-rpc-core/src/main/java/com/sinjinsong/toy/common/context/RPCThreadSharedContext.java b/toy-rpc-core/src/main/java/com/sinjinsong/toy/common/context/RPCThreadSharedContext.java
@@ -11,28 +11,28 @@
 /**
  * @author sinjinsong
  * @date 2018/6/10
- * 
  * 线程共享
+ * 不可以使用ThreadLocal来存放，因为发出请求的线程（如main）和接受响应的线程（某个eventloop）不能保证是同一个线程
  */
 @Slf4j
 public class RPCThreadSharedContext {
     private static final ConcurrentHashMap<String, CompletableFuture<RPCResponse>> RESPONSES = new ConcurrentHashMap<>();
-    private static final ConcurrentHashMap<String,ServiceConfig<?>> HANDLER_MAP = new ConcurrentHashMap<>();
-    
+    private static final ConcurrentHashMap<String, ServiceConfig<?>> HANDLER_MAP = new ConcurrentHashMap<>();
+
     public static void registerResponseFuture(String requestId, CompletableFuture<RPCResponse> future) {
         RESPONSES.put(requestId, future);
     }
 
     public static CompletableFuture<RPCResponse> getAndRemoveResponseFuture(String requestId) {
         return RESPONSES.remove(requestId);
     }
-    
-    public static void registerHandler(String name,ServiceConfig serviceConfig) {
+
+    public static void registerHandler(String name, ServiceConfig serviceConfig) {
         HANDLER_MAP.put(name,
                 serviceConfig);
     }
-    
+
     public static ServiceConfig getAndRemoveHandler(String name) {
-         return HANDLER_MAP.remove(name);
+        return HANDLER_MAP.remove(name);
     }
 }