Rails 4 compatibility #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes enable Rails 4 support, while also maintaining compatibility with Rails 3.2+ 1. Call attr_accessible only when using ActiveRecord < 4 or when using the 'protected attributes' gem 2. Rename the longest database index to allow tests to run in Rails 4 3. Update the README regarding the use of filtered params 4. Change gemspec and require statements to remove references to protected_attributes, and allow ActiveRecord > 3.2
|
+1! |
This was referenced May 29, 2014
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #62, but designed not only to support Rails 4 (without the 'protected_attributes' gem), but also works with Rails 3.2 and with Rails 4+ when using the 'protected_attributes' gem. Also, when checking out this project, the tests should all pass with the default configuration, and the documentation has been updated to mention filtered parameters.