Adding StartupProbe for long upgrade intervals #271
Conversation
| @@ -3,7 +3,7 @@ name: nexus-iq-server | |||
|
|
|||
| # This is the chart version. This version number should be incremented each time you make changes | |||
| # to the chart and its templates, including the app version. | |||
| version: 161.0.0 | |||
| version: 161.0.1 | |||
There was a problem hiding this comment.
This does not require any update (unless you want to publish the chart manually to artifacthub immediately). The next planned release (162) will update this line and publish the chart automatically to artifacthub.
There was a problem hiding this comment.
As 162 is already released, have to perform the changes to new version now.
Would need a new chart version, like 162.0.1
| periodSeconds: 10 | ||
| failureThreshold: 900 |
There was a problem hiding this comment.
Out of curiosity, how was this value determined? As it is the worst case it could wait about 900 * 10 seconds, which comes to about 2 and half hours.
There was a problem hiding this comment.
2.5 hours was taken as a guess number, which should cover 80% of the upgrade scenarios.
When following Sonatype's recommendation of using external database for our products, this time should handle 95% of cases.
When large H2 DB's are in use, during upgrades, schema changes takes long time, at times days.
Description of Change
Added StartupProbe to handle long upgrade intervals (current setting with 2.5 hours).
Things to Do Before Submitting
(See the README)
helm linton your change?