Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEXUS-42658 - Refactoring Jenkinsfiles #184

Conversation

jbermudezsonatype
Copy link
Contributor

@jbermudezsonatype jbermudezsonatype commented May 9, 2024

Changes description

(🚀 Feature)
Refactoring Jenkinsfiles to improve readability

Context

The work intended for this PR's ticket has been already done on https://sonatype.atlassian.net/browse/NEXUS-42436.
So, the work related to this PR was redirected into refactoring the Jenkinsfiles to improve readability.

Ticket ID

Jenkins CI

⚠️⚠️⚠️ Tests branch ⚠️⚠️⚠️
The branch used for testing was the following one:
https://github.com/sonatype/docker-nexus3/tree/feat-NEXUS-42658-parameterizeDockerInternalReleaseJDK17-CITests

ℹ️ NOTE: Since the Jenkinsfiles are related to production processes the tests were performed commenting the actual tasks execution and printing the changes. The prints can be searched with the "::" string.
Example:
image

Jenkinsfile-Internal-Release

Jenkins.rh

Jenkins-Release

@jbermudezsonatype jbermudezsonatype self-assigned this May 9, 2024
@jbermudezsonatype jbermudezsonatype requested a review from a team May 9, 2024 15:15
@jbermudezsonatype jbermudezsonatype force-pushed the feat-NEXUS-42658-parameterizeDockerInternalReleaseJDK17 branch 2 times, most recently from 96e4aba to c4cd7d8 Compare May 15, 2024 15:00
@jbermudezsonatype jbermudezsonatype force-pushed the feat-NEXUS-42658-parameterizeDockerInternalReleaseJDK17 branch from c4cd7d8 to 6e47c60 Compare May 15, 2024 15:03
Copy link

@jarcilac jarcilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbermudezsonatype jbermudezsonatype merged commit 6bb580f into main May 15, 2024
3 of 4 checks passed
@jbermudezsonatype jbermudezsonatype deleted the feat-NEXUS-42658-parameterizeDockerInternalReleaseJDK17 branch May 15, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants