Support ESP-IDF Install from External Directory #170
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
Thanks a bunch for maintaining this library.
This PR makes it easy to include the library when it is not directly within the
components
directory by simply setting theESP_DMX_ROOT
variable before including theCMakeLists.txt
file.This allows users to create a simple wrapper component like this:
The benefit, to me, is that I can keep all my third-party dependencies / submodules in one place. It makes it easier not to miss one ;)
What do you think?