Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD] sale_order_partner_invoice_period #83

Open
wants to merge 5 commits into
base: 17.0
Choose a base branch
from

Conversation

DantePereyra
Copy link

Adds a selector of period to invoice directions.

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment, and also add pending requirements:

  • For sales orders tree view, the field must be added, as optional and shown by default.
  • For sales orders search view, we should be able to group by this new field.

sale_order_partner_invoice_period/models/res_partner.py Outdated Show resolved Hide resolved
@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from 7426945 to e53debf Compare November 19, 2024 12:57
@DantePereyra
Copy link
Author

Changes done.

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@DantePereyra
Copy link
Author

Changes done.

@dalonsod
Copy link
Contributor

👍 please add README stuff and I'll test it

@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from b22351a to 05fbc74 Compare November 20, 2024 08:50
@DantePereyra
Copy link
Author

Done!

@dalonsod
Copy link
Contributor

@DantePereyra during installation this error is raised:

odoo.tools.convert.ParseError: while parsing /home/david/Solvos/Desarrollo/CodeProjects/odoo-17-oca/slv-sale/sale_order_partner_invoice_period/views/sale_order_view.xml:16
Invalid Expression while parsing xpath "//search//filter[@name='order_month'"

View error context:
'-no context-'

Could you check?

@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from 05fbc74 to 577b55e Compare November 20, 2024 11:44
@DantePereyra
Copy link
Author

Done, it was an end bracket missing. It must work perfect now.

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make these four new tasks:

  • Make invoice_period only available for sales orders tree view, not for quotations. If you inherit from sale.view_order_tree instead of sale.sale_order_tree (base view for both quotations and orders) you'll achieve the desired behavior.
  • Place new field in tree view after invoice_status, that is a better location.
  • Use widget="badge" for this field, as invoice_status does.
  • Add default and es translations.

@DantePereyra
Copy link
Author

All done.

@dalonsod
Copy link
Contributor

Could you provide a screenshoot of some sales orders in the tree view with different invoice periods? I would like to see how badge widget is finally rendered

@DantePereyra
Copy link
Author

imagen
There it is

@dalonsod
Copy link
Contributor

OK... could you add some colors to badges, so each value has a different color? invoice_status field view definition has the key of that IMO. I have no preferences about every color...

@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from 16a95f9 to 0266a7c Compare November 20, 2024 16:42
@DantePereyra
Copy link
Author

imagen
Changes done.

Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comment, and I'll test it ASAP. Good work!

sale_order_partner_invoice_period/i18n/es.po Outdated Show resolved Hide resolved
Adds a selector of period to invoice directions.
@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from 0266a7c to 992476d Compare November 20, 2024 16:58
@DantePereyra
Copy link
Author

Perfect, done and ready! Thanks!

@DantePereyra
Copy link
Author

Changes done with new requirements.

@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from fa42fcc to c547fb6 Compare November 22, 2024 10:11
@DantePereyra
Copy link
Author

Added the last requirements.

@DantePereyra DantePereyra force-pushed the 17.0-add-sale_order_partner_invoice_period branch from 9d8c944 to 27748aa Compare November 26, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants