-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][ADD] sale_order_partner_invoice_period #83
base: 17.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment, and also add pending requirements:
- For sales orders tree view, the field must be added, as optional and shown by default.
- For sales orders search view, we should be able to group by this new field.
7426945
to
e53debf
Compare
Changes done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
Changes done. |
👍 please add README stuff and I'll test it |
b22351a
to
05fbc74
Compare
Done! |
@DantePereyra during installation this error is raised:
Could you check? |
05fbc74
to
577b55e
Compare
Done, it was an end bracket missing. It must work perfect now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make these four new tasks:
- Make
invoice_period
only available for sales orders tree view, not for quotations. If you inherit fromsale.view_order_tree
instead ofsale.sale_order_tree
(base view for both quotations and orders) you'll achieve the desired behavior. - Place new field in tree view after
invoice_status
, that is a better location. - Use
widget="badge"
for this field, asinvoice_status
does. - Add default and
es
translations.
All done. |
Could you provide a screenshoot of some sales orders in the tree view with different invoice periods? I would like to see how badge widget is finally rendered |
OK... could you add some colors to badges, so each value has a different color? |
16a95f9
to
0266a7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See minor comment, and I'll test it ASAP. Good work!
Adds a selector of period to invoice directions.
0266a7c
to
992476d
Compare
Perfect, done and ready! Thanks! |
Changes done with new requirements. |
fa42fcc
to
c547fb6
Compare
Added the last requirements. |
9d8c944
to
27748aa
Compare
Adds a selector of period to invoice directions.