Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][ADD] sale_order_remove_portal_timesheet #53

Open
wants to merge 1 commit into
base: 15.0
Choose a base branch
from
Open

[15.0][ADD] sale_order_remove_portal_timesheet #53

wants to merge 1 commit into from

Conversation

LucPinheiro
Copy link
Contributor

dalonsod
dalonsod requested changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. And also, is it possible to add a ROADMAP section to readme documentation? In this section, we could warn about the current view inheritance, that can be improved in the future, if we find a good xpath solution.

sale_order_remove_portal_timesheet/__manifest__.py Show resolved Hide resolved
sale_order_remove_portal_timesheet/__manifest__.py Outdated Show resolved Hide resolved
sale_order_remove_portal_timesheet/readme/DESCRIPTION.rst Outdated Show resolved Hide resolved
dalonsod
dalonsod reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@dalonsod dalonsod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it ASAP. Could you squash commits, if possible?

@LucPinheiro LucPinheiro force-pushed the 15.0-add-sale_order_remove_portal_timesheet branch from 5d7df89 to e75a189 Compare February 16, 2023 15:54
@dalonsod
Copy link
Contributor

dalonsod commented Feb 16, 2023 •
edited
Loading

There's a problem with commits. In commit history there are commits that shouldn't belong to this PR:

imagen

Indeed, files of other folder appear in this PR:

imagen

Could you check?
Remember: every PR and its associated new branch must start from main branch (in this, case, 15.0) and then add the changes needed

@LucPinheiro LucPinheiro force-pushed the 15.0-add-sale_order_remove_portal_timesheet branch from e75a189 to bde17b4 Compare February 17, 2023 11:40
@LucPinheiro LucPinheiro force-pushed the 15.0-add-sale_order_remove_portal_timesheet branch from bde17b4 to 291d197 Compare February 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucPinheiro @dalonsod