Fix rubocop issues, drop EOL ruby versions

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [ '2.7', '3.0', '3.1', '3.2', head ]
+        ruby-version: [ '3.0', '3.1', '3.2', '3.3', 'head' ]
 
     steps:
     - uses: actions/checkout@v3

.rubocop.yml

@@ -15,6 +15,8 @@ inherit_gem:
     - config/ruby-3.0.yml
 
 AllCops:
+  # Last supported version before EOL
+  # See: https://endoflife.date/ruby
   TargetRubyVersion: 3.0
   NewCops: enable
   Exclude:

.standard.yml

@@ -0,0 +1,4 @@
+# Last supported version before EOL
+# See: https://endoflife.date/ruby
+ruby_version: 3.0
+format: progress

Rakefile

@@ -3,15 +3,11 @@
 require "bundler/gem_tasks"
 require "appraisal"
 require "rspec/core/rake_task"
-require "rubocop/rake_task"
-require "standard/rake"
-
-RSpec::Core::RakeTask.new(:spec)
-RuboCop::RakeTask.new
 
 desc "Run the full CI"
 task :default do
   if ENV["APPRAISAL_INITIALIZED"]
+    RSpec::Core::RakeTask.new(:spec)
     Rake::Task["spec"].invoke
   else
     # FYI: Standard & appraisal requires each a spawn process.
@@ -26,6 +22,6 @@ task :default do
 
     fail unless system "bundle exec appraisal rspec"
     fail unless system "bundle exec rubocop"
-    fail unless system "bundle exec rake standard"
+    fail unless system "bundle exec standardrb"
   end
 end

lib/caoutsearch/model/indexable.rb

@@ -19,8 +19,8 @@ def index_with(index_class)
       end
 
       module ClassMethods
-        def reindex(*properties, **options, &block)
-          index_engine_class.reindex(all, *properties, **options, &block)
+        def reindex(...)
+          index_engine_class.reindex(all, ...)
         end
 
         def delete_indexes

lib/caoutsearch/search/callbacks.rb

@@ -11,16 +11,16 @@ module Callbacks
       end
 
       class_methods do
-        def before_build(*filters, &blk)
-          set_callback(:build, :before, *filters, &blk)
+        def before_build(...)
+          set_callback(:build, :before, ...)
         end
 
-        def after_build(*filters, &blk)
-          set_callback(:build, :after, *filters, &blk)
+        def after_build(...)
+          set_callback(:build, :after, ...)
         end
 
-        def around_build(*filters, &blk)
-          set_callback(:build, :around, *filters, &blk)
+        def around_build(...)
+          set_callback(:build, :around, ...)
         end
       end
     end

lib/caoutsearch/search/dsl/item.rb

@@ -32,7 +32,7 @@ def inspect
 
         def properties_to_inspect
           PROPERTIES_TO_INSPECT.each_with_object({}) do |name, properties|
-            value = instance_variable_get("@#{name}")
+            value = instance_variable_get(:"@#{name}")
             properties[name] = value.inspect if value.present?
           end
         end

lib/caoutsearch/search/inspect.rb

@@ -25,7 +25,7 @@ def inspect
 
       def properties_to_inspect
         PROPERTIES_TO_INSPECT.each_with_object({}) do |name, properties|
-          value = instance_variable_get("@#{name}")
+          value = instance_variable_get(:"@#{name}")
           properties[name] = value.inspect if value
         end
       end

spec/caoutsearch/search/batch_methods_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-RSpec.describe Caoutsearch::Search::BatchMethods, active_record: true do
+RSpec.describe Caoutsearch::Search::BatchMethods, :active_record do
   let(:search_class) { stub_search_class("SampleSearch") }
   let(:search) { search_class.new }
   let(:records) { Array.new(12) { Sample.create } }

spec/caoutsearch/search/records_spec.rb

@@ -2,7 +2,7 @@
 
 require "spec_helper"
 
-RSpec.describe Caoutsearch::Search::Records, active_record: true do
+RSpec.describe Caoutsearch::Search::Records, :active_record do
   let!(:search) { search_class.new }
   let!(:search_class) { stub_search_class("SampleSearch") }
 

spec/spec_helper.rb

@@ -26,7 +26,7 @@
     expect.syntax = :expect
   end
 
-  config.before :context, active_record: true do
+  config.before :context, :active_record do
     require "database_cleaner/active_record"
     require "active_record"
 
@@ -47,7 +47,7 @@
     DatabaseCleaner.cleaning { example.run }
   end
 
-  config.after :context, active_record: true do
+  config.after :context, :active_record do
     ActiveRecord::Schema.define do
       suppress_messages do
         drop_table :samples