Update ca.po #19
Open
Update ca.po #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some improvements.
|
Some improvements. |
ikeydoherty
reviewed
Feb 14, 2018
| @@ -659,12 +659,12 @@ msgstr "El repositori %s no existeix. No es pot eliminar." | |||
| #: pisi/api.py:839 | |||
| #, python-format | |||
| msgid "Updating repository: %s" | |||
| msgstr "S'actualitza el repositori %s" | |||
| msgstr "S'actualitza el repositori %s." | |||
There was a problem hiding this comment.
Why are these dots being added?
ikeydoherty
requested changes
Feb 14, 2018
|
Hello,
Because it is grammatically more correct, better, and visually not strange
as whithout it when seen in a termnal. Apart from that, complete sentences
should end with a dot. Firstly I chose to respect the original in all
cases...
Punctuation is not the only review I did. I hope it does not take long to
get to the current system.
Thanks and regards,
David Medina
2018-02-14 15:01 GMT+01:00 Ikey Doherty <[email protected]>:
… ***@***.**** requested changes on this pull request.
Not sure why you're adding new punctuation that didn't exist before?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIPV5Auy07UiZl_kmikLKXGYqx7sthqdks5tUudQgaJpZM4RzuoT>
.
|
But you didn't - you altered the context and meaning |
|
As in where, for instance?
The latest review was done taking into account what I have actually seen
applied in my own Solus system.
Is it going to take so much time to just get a translation to the system as
it did before?
2018-03-02 17:56 GMT+01:00 Ikey Doherty <[email protected]>:
… Firstly I chose to respect the original in all cases...
But you didn't - you altered the context and meaning
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIPV5BDZ1igEe8NB2zWH0HViv-VIhXU9ks5taXnWgaJpZM4RzuoT>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements.