Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support notification manipulation (enable / disable) via GNOME Control Center. #1456

Merged
merged 1 commit into from
May 25, 2018

Conversation

JoshStrobl
Copy link
Contributor

This pull request implements support for silencing / (enabling / disabling) notifications via GNOME Control Center, which manipulations applications via /org/gnome/desktop/notifications/application/APPNAME. By default, no enable key is set for these applications, therefore they are enabled and we only apply the setting if the bool key exists.

Note that this doesn't apply to snap applications such as Spotify (which seem to get set by GNOME Control Center with names like spotify-spotify instead of just spotify), but figured it'd be better than nothing.

This has been tested against:

  • Peek
  • Rhythmbox
  • Spotify (Snap)
  • notify-send: To validate that there shouldn't be critical issues if it fails to get a schema.

Further notes:

@ikeydoherty
Copy link
Member

GRMA :D

@ikeydoherty ikeydoherty merged commit c529558 into solus-project:master May 25, 2018
@JoshStrobl JoshStrobl deleted the silence branch May 25, 2018 10:44
@fn-ix
Copy link

fn-ix commented May 29, 2018

I don't believe this solves #1286: it only allows enabling and disabling of notifications, not of their appearing in the notifications drawer separately from the pop-up, besides the option to have no pop-up but still have an entry in the drawer (but not vice versa, which was the point of #1286).

I.e. I'd like an e-mail notification to end up in the drawer and highlight the bell, whilst still getting pop-ups from a music player about the new song or a "ready to unmount" message from the file manager, but not have them populate the drawer, making it useless as an indicator of rarer and more important events and forcing me to regularly empty it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evolution notifications
3 participants