-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(map_image): Replaced kpartx with losetup #115
Conversation
losetup is part of util-linux and should be preinstalled on most of linux distributions
Waiting for approval from someone in the solo-io org to start testing. |
@@ -111,6 +110,7 @@ Build the `samples/raspbian_golang.json` Packer image | |||
docker run \ | |||
--rm \ | |||
--privileged \ | |||
-v /dev:/dev \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with --privileged
docker doesn't update /dev filesystem automatically, and because of that, newly created partitions don't appear inside container. This is really old bug and bind mounting of /dev seems to be official solution
@eaglesemanation thanks! I think this requires some manual testing, as current CI doesn't check image building; will give it a try tonight! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, thank you!
FWIW this breaks running the Standalone build on macOS, which does not include Edit: at least this change is an issue, but even reverting this I'm still not able to get this running via any method in the README (Vagrant, Docker or Standalone) on macOS. I did have this running successfully ~a year ago and was able to flash a Raspberry PI with an image build from a sample file, at some point prior to the repo rename from
Edit (2021-12-27): Vagrant workflow no longer seems blocked on the above issue after upgrading the VirtualBox v6.1.30, but both the Vagrant and Docker builds are now failing with the issue described in #124 |
Implementation for #113
losetup is part of util-linux and should be preinstalled on most of
linux distributions