Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_image): Replaced kpartx with losetup #115

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

eaglesemanation
Copy link
Contributor

Implementation for #113

losetup is part of util-linux and should be preinstalled on most of
linux distributions

losetup is part of util-linux and should be preinstalled on most of
linux distributions
@solo-build-bot
Copy link

Waiting for approval from someone in the solo-io org to start testing.

@@ -111,6 +110,7 @@ Build the `samples/raspbian_golang.json` Packer image
docker run \
--rm \
--privileged \
-v /dev:/dev \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even with --privileged docker doesn't update /dev filesystem automatically, and because of that, newly created partitions don't appear inside container. This is really old bug and bind mounting of /dev seems to be official solution

@yuval-k
Copy link
Member

yuval-k commented Oct 18, 2021

@eaglesemanation thanks! I think this requires some manual testing, as current CI doesn't check image building; will give it a try tonight!

Copy link
Member

@yuval-k yuval-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me, thank you!

@yuval-k yuval-k merged commit 4ca5b43 into solo-io:master Oct 19, 2021
@mikemorris
Copy link

mikemorris commented Nov 4, 2021

FWIW this breaks running the Standalone build on macOS, which does not include losetup or have it available via Homebrew - it may be possible to alternately use hdiutil on macOS instead?

Edit: at least this change is an issue, but even reverting this I'm still not able to get this running via any method in the README (Vagrant, Docker or Standalone) on macOS. I did have this running successfully ~a year ago and was able to flash a Raspberry PI with an image build from a sample file, at some point prior to the repo rename from packer-builder-arm-image, not quite sure yet all of what's broken as it looks like there have been some substantial changes. git bisect or rewinding through commit history to find a breaking point has not been particularly helpful due to some of the remote dependencies which are now gone.

The Vagrant workflow seems to be failing on hashicorp/vagrant#12557 (comment) for me, so not necessarily a problem with this project - haven't tracked down why the Docker build is failing yet.

Edit (2021-12-27): Vagrant workflow no longer seems blocked on the above issue after upgrading the VirtualBox v6.1.30, but both the Vagrant and Docker builds are now failing with the issue described in #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants