Merge pull request #27 from solideal/ci-patch-1

Update continuous-integration.yml
solideal · Sep 15, 2020 · 3965f27 · 3965f27
2 parents f176ace + 47fa52b
commit 3965f27
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -33,7 +33,7 @@ jobs:
     name: Send Sonarcloud analysis
     runs-on: ubuntu-20.04
     needs: [test]
-    if: github.event_name == 'pull_request'
+    if: github.event_name == 'pull_request' # requires Sonar only on pull request since every new code goes through it
     steps:
       - uses: actions/checkout@v2
         with:
@@ -45,7 +45,7 @@ jobs:
   deploy:
     name: Deploy on npm
     runs-on: ubuntu-20.04
-    needs: [sonar, test]
+    needs: test
     if: github.ref == 'refs/heads/master' && github.event_name == 'push' # Deploy only on the master branch and push event
     steps:
       - name: Checkout