PATCH/PUT Append to create a new resource #56
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -196,8 +196,8 @@ describe('Create', () => { | |
| testAllowed('Write', 'Write'); | ||
| testAllowed('Append', 'Write'); | ||
|
|
||
| it(`is allowed with Append on c/r (create new resource)`, async () => { | ||
| const testing = `allowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
|
|
@@ -229,6 +229,42 @@ describe('Create', () => { | |
| 'If-None-Match': '*' | ||
| } | ||
| }); | ||
| expect(result.status).toEqual(201); | ||
| }); | ||
|
|
||
| it(`is disallowed with Append on c/r (existing resource)`, async () => { | ||
| const testing = `test-disallowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
| method: 'PUT', | ||
| body: 'hello', | ||
| headers: { | ||
| 'Content-Type': 'text/plain', | ||
| 'If-None-Match': '*' | ||
| } | ||
| }); | ||
| const aclDocUrl = await solidLogicAlice.findAclDocUrl(containerUrl); | ||
| await solidLogicAlice.fetch(aclDocUrl, { | ||
| method: 'PUT', | ||
| body: makeBody({ | ||
| containerModes: 'acl:Read, acl:Append, acl:Write, acl:Control', | ||
| resourceModes: 'acl:Read, acl:Append, acl:Control', | ||
| target: containerUrl | ||
| }), | ||
| headers: { | ||
| 'Content-Type': 'text/turtle', | ||
| // 'If-None-Match': '*' - work around a bug in some servers that don't support If-None-Match on ACL doc URLs | ||
| } | ||
| }); | ||
| const result = await solidLogicBob.fetch(`${containerUrl}test.txt`, { | ||
| method: 'PUT', | ||
| body: 'hello', | ||
| headers: { | ||
| 'Content-Type': 'text/plain', | ||
| // 'If-None-Match': '*' // precondition may be tested before and return 412 | ||
| } | ||
| }); | ||
| expect(result.status).toEqual(403); | ||
| }); | ||
|
|
||
|
|
@@ -313,8 +349,8 @@ describe('Create', () => { | |
| testAllowed('Write', 'Write'); | ||
| testAllowed('Append', 'Write'); | ||
|
|
||
| it(`is allowed with Append on c/r`, async () => { | ||
| const testing = `allowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
|
|
@@ -350,7 +386,7 @@ describe('Create', () => { | |
| "<#patch> a solid:InsertDeletePatch;\n" + | ||
| " solid:inserts { <#hello> <#linked> <#world> .}.\n", | ||
| }); | ||
| expect(responseCodeGroup(result.status)).toEqual("2xx"); | ||
| }); | ||
|
|
||
| it(`is disallowed without Write or Append on c/`, async () => { | ||
|
|
@@ -435,8 +471,8 @@ describe('Create', () => { | |
| testAllowed('Write', 'Write'); | ||
| testAllowed('Append', 'Write'); | ||
|
|
||
| it(`is allowed with Append on c/r (create new resource)`, async () => { | ||
| const testing = `allowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
|
|
@@ -468,7 +504,7 @@ describe('Create', () => { | |
| 'If-None-Match': '*' | ||
| } | ||
| }); | ||
| expect(result.status).toEqual(201); | ||
| }); | ||
|
|
||
| it(`is disallowed without Write or Append on c/`, async () => { | ||
|
|
@@ -554,8 +590,8 @@ describe('Create', () => { | |
| testAllowed('Write', 'Write'); | ||
| testAllowed('Append', 'Write'); | ||
|
|
||
| it(`is allowed with Append on c/r`, async () => { | ||
| const testing = `allowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
|
|
@@ -589,11 +625,11 @@ describe('Create', () => { | |
| "<#patch> a solid:InsertDeletePatch;\n" + | ||
| " solid:inserts { <#hello> <#linked> <#world> .}.\n", | ||
| }); | ||
| expect(responseCodeGroup(result.status)).toEqual("2xx"); | ||
| }); | ||
|
|
||
| it(`is allowed with Append on c/`, async () => { | ||
| const testing = `allowed-default`; | ||
| const containerUrl = makeContainerUrl(testFolderUrl, using, testing); | ||
| // This will do mkdir-p: | ||
| await solidLogicAlice.fetch(`${containerUrl}test.txt`, { | ||
|
|
@@ -627,7 +663,7 @@ describe('Create', () => { | |
| "<#patch> a solid:InsertDeletePatch;\n" + | ||
| " solid:inserts { <#hello> <#linked> <#world> .}.\n", | ||
| }); | ||
| expect(result.status).toEqual(200); | ||
|
There was a problem hiding this comment. Not sure if I agree. This test is about required permissions on There was a problem hiding this comment. @michielbdejong I should have added this link as a clarification on WAC |
||
| }); | ||
| }); | ||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name to the test artifact below should be changed to match the test purpose to avoid future confusion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I commit my changes to testing