Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kube-state-metrics sub-chart to 5.28.0 #857

Merged
merged 1 commit into from
Jan 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions deploy/helm/Chart.lock
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
dependencies:
- name: kube-state-metrics
repository: https://prometheus-community.github.io/helm-charts
version: 5.26.0
version: 5.28.0
- name: opentelemetry-operator
repository: https://open-telemetry.github.io/opentelemetry-helm-charts
version: 0.68.3
- name: cert-manager
repository: https://charts.jetstack.io
version: v1.16.1
digest: sha256:531536930d6703d7eac1fef0edc60b586790199100d10af78f82a58ba839694b
generated: "2024-11-11T10:34:43.72979+01:00"
digest: sha256:38d69a6382829ee33fd382ba95f1b7b5c7751f0d011e4c0881c4e28321713334
generated: "2025-01-06T09:28:44.7431325+01:00"
2 changes: 1 addition & 1 deletion deploy/helm/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ maintainers:
dependencies:
- name: kube-state-metrics
repository: https://prometheus-community.github.io/helm-charts
version: "~> 5.26.0"
version: "~> 5.28.0"
condition: kube-state-metrics.enabled
- name: opentelemetry-operator
repository: https://open-telemetry.github.io/opentelemetry-helm-charts
Expand Down
2 changes: 0 additions & 2 deletions deploy/helm/metrics-collector-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -862,8 +862,6 @@ processors:
name == "kube_service_spec_type" or
name == "kube_service_spec_external_ip" or
name == "kube_service_status_load_balancer_ingress" or
name == "kube_endpoint_address_not_ready" or
name == "kube_endpoint_address_available" or
name == "kube_endpoint_info" or
name == "kube_endpoint_created" or
name == "kube_endpoint_ports" or
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ Metrics config should match snapshot when using default values:
or\nname == \"kube_persistentvolumeclaim_created\" or\nname == \"kube_pod_spec_volumes_persistentvolumeclaims_info\"
or\nname == \"kube_service_info\" or\nname == \"kube_service_created\" or\nname
== \"kube_service_spec_type\" or\nname == \"kube_service_spec_external_ip\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_address_not_ready\"
or\nname == \"kube_endpoint_address_available\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_endpoint_created\" or\nname == \"kube_endpoint_ports\"
or\nname == \"kube_endpoint_address\"\n)\n"
filter/preprocessing:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ Metrics config should match snapshot when fargate is enabled:
or\nname == \"kube_persistentvolumeclaim_created\" or\nname == \"kube_pod_spec_volumes_persistentvolumeclaims_info\"
or\nname == \"kube_service_info\" or\nname == \"kube_service_created\" or\nname
== \"kube_service_spec_type\" or\nname == \"kube_service_spec_external_ip\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_address_not_ready\"
or\nname == \"kube_endpoint_address_available\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_endpoint_created\" or\nname == \"kube_endpoint_ports\"
or\nname == \"kube_endpoint_address\"\n)\n"
filter/preprocessing:
Expand Down Expand Up @@ -2129,8 +2128,7 @@ Metrics config should match snapshot when using Prometheus url with extra_scrape
or\nname == \"kube_persistentvolumeclaim_created\" or\nname == \"kube_pod_spec_volumes_persistentvolumeclaims_info\"
or\nname == \"kube_service_info\" or\nname == \"kube_service_created\" or\nname
== \"kube_service_spec_type\" or\nname == \"kube_service_spec_external_ip\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_address_not_ready\"
or\nname == \"kube_endpoint_address_available\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_endpoint_created\" or\nname == \"kube_endpoint_ports\"
or\nname == \"kube_endpoint_address\"\n)\n"
filter/preprocessing:
Expand Down Expand Up @@ -3927,8 +3925,7 @@ Metrics config should match snapshot when using default values:
or\nname == \"kube_persistentvolumeclaim_created\" or\nname == \"kube_pod_spec_volumes_persistentvolumeclaims_info\"
or\nname == \"kube_service_info\" or\nname == \"kube_service_created\" or\nname
== \"kube_service_spec_type\" or\nname == \"kube_service_spec_external_ip\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_address_not_ready\"
or\nname == \"kube_endpoint_address_available\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_service_status_load_balancer_ingress\" or\nname == \"kube_endpoint_info\"
or\nname == \"kube_endpoint_created\" or\nname == \"kube_endpoint_ports\"
or\nname == \"kube_endpoint_address\"\n)\n"
filter/preprocessing:
Expand Down
2 changes: 0 additions & 2 deletions doc/exported_metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,6 @@ The following tables contain the list of all metrics exported by the swi-k8s-ope
| Metric | Type | Unit | Description | native/custom |
| --- | --- | --- | --- | --- |
| k8s.kube_endpoint_annotations| Gauge | | Kubernetes annotations converted to Prometheus labels | native |
| k8s.kube_endpoint_address_not_ready| Gauge | | | native |
| k8s.kube_endpoint_address_available| Gauge | | | native |
| k8s.kube_endpoint_info| Gauge | | Information about Endpoint | native |
| k8s.kube_endpoint_labels| Gauge | | Kubernetes labels converted to Prometheus labels | native |
| k8s.kube_endpoint_created| Gauge | | Unix creation timestamp | native |
Expand Down
5 changes: 4 additions & 1 deletion tests/deploy/tests/test_metric_manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ spec:
- name: test-container
image: busybox
command: ["sh", "-c", "sleep infinity"]
ports:
- containerPort: 80
name: http-web-svc
---
apiVersion: apps/v1
kind: ReplicaSet
Expand Down Expand Up @@ -197,7 +200,7 @@ metadata:
example.com/annotation: "example-annotation"
spec:
selector:
app: test-pod
app: test-statefulset
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kube_endpoint_address is generated only when there is an actual endpoint mapped to the service. Fixing the link between test-statefulset and test-service, since the StatefulSet already pointed to Service, just not the other way around.

ports:
- name: test-service-port
protocol: TCP
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/expected_metric_names.txt
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ k8s.kube_deployment_status_replicas_available
k8s.kube_deployment_status_replicas_ready
k8s.kube_deployment_status_replicas_unavailable
k8s.kube_deployment_status_replicas_updated
k8s.kube_endpoint_address_available
k8s.kube_endpoint_address_not_ready
k8s.kube_endpoint_address
k8s.kube_endpoint_created
k8s.kube_endpoint_info
k8s.kube_endpoint_ports
Expand Down
3 changes: 1 addition & 2 deletions tests/integration/expected_telemetry/service.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"metrics": [
{ "name": "k8s.kube_endpoint_address_available" },
{ "name": "k8s.kube_endpoint_address_not_ready" },
{ "name": "k8s.kube_endpoint_address" },
{ "name": "k8s.kube_endpoint_created" },
{ "name": "k8s.kube_endpoint_info" },
{ "name": "k8s.kube_service_created" },
Expand Down
Loading