Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NH-65713 Adjust exporter defaults and restrictions #217

Merged
merged 9 commits into from
Nov 14, 2023
Merged

NH-65713 Adjust exporter defaults and restrictions #217

merged 9 commits into from
Nov 14, 2023

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Nov 10, 2023 •
edited
Loading

Before

Whether in lambda or outside:

  1. No default for OTEL_METRICS_EXPORTER
  2. OTEL_TRACES_EXPORTER defaulted to solarwinds_exporter
  3. If OTEL_TRACES_EXPORTER configured, required to include solarwinds_exporter else agent disabled

After

In lambda:

  1. OTEL_METRICS_EXPORTER defaults to otlp_proto_http
  2. OTEL_TRACES_EXPORTER defaults to otlp_proto_http

Out of lambda:

  1. No default for OTEL_METRICS_EXPORTER. If experimental flag is set, customers must configure metrics exporters else none will initialize.
  2. OTEL_TRACES_EXPORTER defaults to solarwinds_exporter
    • (same as before, to not break)

Note: Metrics exporters will only be initialized if experimental flag is set, for both scenarios.

Please let me know what you think!

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review November 10, 2023 01:27
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner November 10, 2023 01:27
cheempz
cheempz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tammy-baylis-swi!

@tammy-baylis-swi tammy-baylis-swi merged commit 769e852 into main Nov 14, 2023
11 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-65713-exporter-defaults branch November 14, 2023 20:13
@tammy-baylis-swi tammy-baylis-swi mentioned this pull request Nov 20, 2023
Closed
This was referenced Feb 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheempz cheempz cheempz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tammy-baylis-swi @cheempz