Refactor Cache Internal Classes #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #89, we introduced the Subscription API and split the Client I/F and Cache implementation into two: * SwrClient - SwrCache * SwrClientPlus - SwrCachePlus Previously, SwrCache and SwrCachePlus had a direct inheritance relationship. This refactor extracts the internal logic and removes the inheritance. With this change, the soil-query-testing library can now define the same extension functions for both: ``` val testClient1 = SwrCache(..).test() val testClient2 = SwrCachePlus(..).test() ```
ogaclejapan
force-pushed
the
refactor-swr-cache-internal
branch
from
be7b3ee to
c4d7ca9
Compare
ogaclejapan
added a commit
that referenced
this pull request
Nov 30, 2024
Implemented `isIdleNow` function, which can be used with `IdlingResource` or `waitUntil`,and `awaitIdle` suspend function for Compose UI testing, utilizing the `SwrCacheView` introduced in #135. Previously, it was not possible to determine whether there were ongoing operations within the cache. With these new functions, it is now possible to synchronize with Compose test functions for proper coordination during testing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #89, we introduced the Subscription API and split the Client I/F and Cache implementation into two:
Previously, SwrCache and SwrCachePlus had a direct inheritance relationship. This refactor extracts the internal logic and removes the inheritance.
With this change, the soil-query-testing library can now define the same extension functions for both: