Tweak MutatedEffect #133
Merged
Tweak MutatedEffect #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it was introduced in #131, `replyUpdatedAt` was used as the default value for `keySelector`. However, an issue was discovered during unit testing. Since `replyUpdatedAt` handles epoch time in seconds, the success callback was not triggered when updates occurred at intervals of less than a second. The unit test, which performed multiple updates within sub-second intervals, helped uncover this issue.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it was introduced in #131,
replyUpdatedAtwas used as the default value forkeySelector. However, an issue was discovered during unit testing. SincereplyUpdatedAthandles epoch time in seconds, the success callback was not triggered when updates occurred at intervals of less than a second. The unit test, which performed multiple updates within sub-second intervals, helped uncover this issue.