Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix float classes #34

Merged
merged 5 commits into from
Jul 29, 2024
Merged

Conversation

tom-hg57
Copy link
Collaborator

@tom-hg57 tom-hg57 commented Jul 25, 2024

Recognition as Float for C++/Java is not correct for some classes and attributes:

  • Some CGMES_2 classes has to be recognized as float, e.g. ActivePowerPerFrequency. These classes contain only a simple float value. All other attributes (multiplier, unit, denominatorMultiplier, denominatorUnit) are fixed.
  • For CGMES_3 the Float class itself has to be recognized as simple float to prevent that it is treated as pointer to an object, e.g. position in SvTapStep.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
26.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@stv0g stv0g merged commit f6969d3 into sogno-platform:master Jul 29, 2024
7 checks passed
@tom-hg57 tom-hg57 deleted the fix-float-classes branch July 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants