Class-based architecture for deposition plugins #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyzzyxdonta
force-pushed
the
feature/class-based-plugins
branch
from
5959f6f to
26a649f
Compare
led02
reviewed
Oct 16, 2023
|
Maybe we should also write an ADR about this... now that HEQATE is not coming, we need to ensure quality ourselves 😭 |
|
Yup, I also thought about writing an ADR and was going to address it at the next JF 😄 |
zyzzyxdonta
force-pushed
the
feature/class-based-plugins
branch
from
5e2ef00 to
3d2f8f3
Compare
Mostly entry point → plugin
This makes initializing the resolver with a context obsolete.
zyzzyxdonta
changed the title
zyzzyxdonta
requested review from
sdruskat,
led02,
poikilotherm and
SKernchen
sdruskat
reviewed
Dec 14, 2023
led02
requested changes
Dec 18, 2023
There was a problem hiding this comment.
chore: There are some points that should be changed, but the general idea looks good.
question: Do we want to allow to override single process steps with a custom implementation or does this mean that you need to write yet another plugin (i.e., derive from the class that you want to modify and only adapt the respective part)?
led02
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request converts the existing deposition plugins into classes which makes reuse and customization easier and prevents functions from having to load context and config over and over again.