Merge pull request #59 from ldrygala/tests-for-modify-polymorphic-field

add tests for modify polymorphic field
softwaremill · May 17, 2020 · 84fd34d · 84fd34d
2 parents 4c5defa + d0a52f5
commit 84fd34d
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/quicklens/src/test/scala/com/softwaremill/quicklens/ModifyPimpTest.scala b/quicklens/src/test/scala/com/softwaremill/quicklens/ModifyPimpTest.scala
@@ -19,4 +19,8 @@ class ModifyPimpTest extends AnyFlatSpec with Matchers {
   it should "modify several fields" in {
     b1.modifyAll(_.b2, _.b3.each).using(duplicate) should be(b1dupdup)
   }
+
+  it should "modify polymorphic case class field" in {
+    aPoly.modify(_.poly).using(duplicate) should be(aPolyDup)
+  }
 }
diff --git a/quicklens/src/test/scala/com/softwaremill/quicklens/ModifySimpleTest.scala b/quicklens/src/test/scala/com/softwaremill/quicklens/ModifySimpleTest.scala
@@ -25,7 +25,22 @@ class ModifySimpleTest extends AnyFlatSpec with Matchers {
     modify(a5)(_.name).usingIf(true)(duplicate) should be(a5dup)
   }
 
-  it should "leave a case class unchanged if the condition is flase" in {
+  it should "leave a case class unchanged if the condition is false" in {
     modify(a5)(_.name).usingIf(false)(duplicate) should be(a5)
   }
+
+  it should "modify polymorphic case class field" in {
+    modify(aPoly)(_.poly).using(duplicate) should be(aPolyDup)
+  }
+
+  it should "modify polymorphic case class field using apply" in {
+    modify(aPoly)(_.poly)(duplicate) should be(aPolyDup)
+  }
+
+  it should "modify polymorphic case class field if condition is true" in {
+    modify(aPoly)(_.poly).usingIf(true)(duplicate) should be(aPolyDup)
+  }
+  it should "leave a polymorphic case class field if condition is false" in {
+    modify(aPoly)(_.poly).usingIf(false)(duplicate) should be(aPoly)
+  }
 }
diff --git a/quicklens/src/test/scala/com/softwaremill/quicklens/TestData.scala b/quicklens/src/test/scala/com/softwaremill/quicklens/TestData.scala
@@ -17,6 +17,10 @@ object TestData {
   val a1dupdup = A1(A2(A3(A4(A5("datadatadatadata")))))
   val a1mod = A1(A2(A3(A4(A5("mod")))))
 
+  case class APoly[T](poly: T, i: Int)
+  val aPoly = APoly("data", 1)
+  val aPolyDup = APoly("datadata", 1)
+
   case class B1(b2: String, b3: Option[String])
 
   val b1 = B1("data", Some("data"))