Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily disable LedgerSigner tests #1477

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Temporarily disable LedgerSigner tests #1477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c33c243
Skip `LedgerSigner` tests
franciszekjob Sep 6, 2024
b42debd
Update skip reason
franciszekjob Sep 6, 2024
e96674b
Remove unused import
franciszekjob Sep 6, 2024
fcb5685
Update directory while building docker Starknet ledger app
franciszekjob Sep 6, 2024
6f9d416
Merge branch 'development' into franciszekjob/temporarily-disable-led…
franciszekjob Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ jobs:
image: ghcr.io/ledgerhq/ledger-app-builder/ledger-app-dev-tools
options: --rm -v ${{ github.workspace }}:/apps
run: |
cd /apps/app-starknet
cd /apps/app-starknet/starknet
cargo clean
cargo ledger build nanox

Expand Down
27 changes: 8 additions & 19 deletions starknet_py/tests/unit/signer/test_ledger_signer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
from sys import platform

import pytest

from starknet_py.common import create_sierra_compiled_contract
Expand All @@ -20,11 +18,8 @@
from starknet_py.tests.e2e.fixtures.misc import load_contract


# TODO (#1425): Currently Ledger tests are skipped on Windows due to different Speculos setup.
@pytest.mark.skipif(
platform == "win32",
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
)
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
@pytest.mark.skip
def test_init_with_invalid_derivation_path():
with pytest.raises(ValueError, match="Empty derivation path"):
LedgerSigner(derivation_path_str="", chain_id=StarknetChainId.SEPOLIA)
Expand Down Expand Up @@ -81,10 +76,8 @@ def test_init_with_invalid_derivation_path():
),
],
)
@pytest.mark.skipif(
platform == "win32",
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
)
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
@pytest.mark.skip
def test_sign_transaction(transaction):
# docs: start

Expand All @@ -104,10 +97,8 @@ def test_sign_transaction(transaction):
assert all(i != 0 for i in signature)


@pytest.mark.skipif(
platform == "win32",
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
)
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
@pytest.mark.skip
def test_create_account_with_ledger_signer():
# pylint: disable=unused-variable
signer = LedgerSigner(
Expand Down Expand Up @@ -141,10 +132,8 @@ async def _get_account_balance_strk(client: FullNodeClient, address: int):


@pytest.mark.asyncio
@pytest.mark.skipif(
platform == "win32",
reason="Testing Ledger is skipped on Windows due to different Speculos setup.",
)
# TODO (#1476): Should be re-enabled once Ledger signer is updated with new APDU spec.
@pytest.mark.skip
async def test_deploy_account_and_transfer(client):
signer = LedgerSigner(
derivation_path_str="m/2645'/1195502025'/1470455285'/0'/0'/0",
Expand Down
Loading