Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ledger setup in CI #1471

Closed
wants to merge 4 commits into from
Closed

Fix ledger setup in CI #1471

wants to merge 4 commits into from

Conversation

kkawula
Copy link
Collaborator

@kkawula kkawula commented Sep 4, 2024

Closes #

Due to app path change, building ledger starknet app was failing.

Introduced changes

  • use /apps/app-starknet/starknet path

  • This PR contains breaking changes

@kkawula kkawula force-pushed the kkawula/fix-ledger-setup branch 2 times, most recently from bbf7c29 to eb1813a Compare September 4, 2024 14:09
@kkawula kkawula marked this pull request as draft September 4, 2024 14:21
@franciszekjob franciszekjob marked this pull request as ready for review September 4, 2024 23:43
@franciszekjob
Copy link
Collaborator

Closing as this will require more changes and will be addresses in PR referring to #1473

@franciszekjob franciszekjob deleted the kkawula/fix-ledger-setup branch September 5, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants