Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early exit from cache save #26

Merged
merged 3 commits into from
Sep 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111,256 changes: 62,750 additions & 48,506 deletions dist/cache-save/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/cache-save/index.js.map

Large diffs are not rendered by default.

554 changes: 155 additions & 399 deletions dist/cache-save/licenses.txt

Large diffs are not rendered by default.

111,257 changes: 62,704 additions & 48,553 deletions dist/setup/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/setup/index.js.map

Large diffs are not rendered by default.

554 changes: 155 additions & 399 deletions dist/setup/licenses.txt

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions lib/cache-save.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,17 @@ async function saveCache() {
} else {
core.info(`Cache hit occurred, not saving cache.`);
}

// node will stay alive if any promises are not resolved,
// which is a possibility if HTTP requests are dangling
// due to retries or timeouts. We know that if we got here
// that all promises that we care about have successfully
// resolved, so simply exit with success.
process.exit(0);
maciektr marked this conversation as resolved.
Show resolved Hide resolved
} catch (e) {
core.error(e);
// vide supra
process.exit(1);
}
}

Expand Down
973 changes: 374 additions & 599 deletions package-lock.json

Large diffs are not rendered by default.

Loading