Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain invalidate of priv_raw_file_content as it is not necessary in current form #13

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Draggu
Copy link
Contributor

@Draggu Draggu commented Dec 3, 2024

Since starkware-libs/cairo#6799, we can use cancel_all as well.
We keep this code to make it clear what we aim to achieve here.

@Draggu Draggu requested a review from a team as a code owner December 3, 2024 10:54
@Draggu Draggu requested review from mkaput and piotmag769 and removed request for a team December 3, 2024 10:54
@Draggu Draggu changed the title Remove invalidate of priv_raw_file_content Explain invalidate of priv_raw_file_content as it is not necessary in current form Dec 4, 2024
@Draggu Draggu force-pushed the spr/main/f1173e60 branch from d7e87af to c2324de Compare December 4, 2024 12:36
@Draggu Draggu requested review from mkaput and piotmag769 December 4, 2024 12:37
…in current form

Since starkware-libs/cairo#6799, we can use `cancel_all` as well.
We keep this code to make it clear what we aim to achieve here.

commit-id:f1173e60
@Draggu Draggu force-pushed the spr/main/f1173e60 branch from c2324de to fcb1a7d Compare December 4, 2024 14:05
@Draggu Draggu added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 4c7e9de Dec 4, 2024
6 checks passed
@Draggu Draggu deleted the spr/main/f1173e60 branch December 4, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants