Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded syscall_counter #23

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

THenry14
Copy link
Member

Closes #20

Introduced changes

  • Remove unneeded syscall_counter and code relevant to it

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@THenry14 THenry14 requested a review from ksew1 October 30, 2024 12:55
Copy link
Member

@ksew1 ksew1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksew1
Copy link
Member

ksew1 commented Nov 3, 2024

I had an afterthought that maybe it is not worth creating ExecutionResources since it only holds VmExecutionResources. Perhaps we should just use this directly? Or do we want to leave some room in case we want to add other fields to ExecutionResources in the future?

@THenry14
Copy link
Member Author

THenry14 commented Nov 4, 2024

I had an afterthought that maybe it is not worth creating ExecutionResources since it only holds VmExecutionResources. Perhaps we should just use this directly? Or do we want to leave some room in case we want to add other fields to ExecutionResources in the future?

Yes, so the plan is to extend this soon-ish, but it wasn't the main reason to do that this way. Having this encapsulated actually follows the layout of the versioned constants file from the sequencer, and ExecutionResources is aimed to hold values parsed from it.

@THenry14 THenry14 merged commit 8cf9f32 into main Nov 4, 2024
4 checks passed
@ksew1 ksew1 deleted the szymczyk/20-remove-syscall-counter branch November 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove syscall_counter
2 participants