Feat/android/gain node #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsek
approved these changes
Jul 25, 2024
|
|
||
| namespace audiocontext { | ||
|
|
||
| using namespace facebook::jni; |
There was a problem hiding this comment.
you are right
example/src/App.tsx
Outdated
| } | ||
| minimumValue={0.0} | ||
| maximumValue={1.0} | ||
| step={0.1} |
There was a problem hiding this comment.
Nitpick: why only 10 steps instead of 100 with step of 0.01 or even go with [0, 100] scope and normalize it when setting a gainRef property
example/src/App.tsx
Outdated
Comment on lines
38
to
50
| const handleSliderChange = ( | ||
| value: number[], | ||
| defaultValue: number, | ||
| setValue: (value: number) => void, | ||
| ref: React.MutableRefObject<{ [key: string]: any } | null>, | ||
| propName: string | ||
| ) => { | ||
| const newValue = value[0] || defaultValue; | ||
| setValue(newValue); | ||
| if (ref.current) { | ||
| ref.current[propName] = newValue; | ||
| } | ||
| }; |
There was a problem hiding this comment.
Didn't notice is earlier, why so over-complicated?
Suggested change
| const handleSliderChange = ( | |
| value: number[], | |
| defaultValue: number, | |
| setValue: (value: number) => void, | |
| ref: React.MutableRefObject<{ [key: string]: any } | null>, | |
| propName: string | |
| ) => { | |
| const newValue = value[0] || defaultValue; | |
| setValue(newValue); | |
| if (ref.current) { | |
| ref.current[propName] = newValue; | |
| } | |
| }; | |
| const handleSliderChange = (value: number[]) => { | |
| const newValue = value[0] || 0.0; | |
| setValue(newValue); | |
| ganinRef.current?.gain = value; | |
| }; |
if we would like to have generic way of modify'ing nodes via sliders we could create a hook and/or components for that
useNodeValue(node: AudioNode) {
// state
// callbacks
// return values?
}
...
useNodeValue(gainNodeRef.current);There was a problem hiding this comment.
Currently I have implemented three handlers each for parameter. In future I will introduce sth like a hook that u mentioned.
|
Fix conflicting files, consider the comments and you can merge this branch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implemented classes for GainNode and whole necessary logic in AudioContext classes
-Implemented get method in AudioNodeHostObject in order to call it from derived classes
-Refactored imports, friend class marks, etc.
Closes: #22