Feat/android/audio context wrapper #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 17, 2024 16:42
…context-wrapper' into feat/android/audio-context-wrapper
…sponsabilities more strict division into jsi and jni class
added 9 commits
July 19, 2024 17:07
michalsek
requested changes
Jul 22, 2024
michalsek
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implemented wrappers' header files for
AudioContext,AudioDestinationNodeandOscillatorNode-Provided wrappers implementation on Android
-Introduced new cpp folder structure
-Refactored jni and jsi classes in order to be consistent with
Single Responsibility Principleand maintain great abstraction level (HybridClass is responsible for interaction with kotlin side(fbjni), wrappers play a compositional role and whole jsi logic is locked in HostObject's classes)Closes: #34