Feat/android/oscillator #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalsek
approved these changes
Jul 12, 2024
| 44100, | ||
| AudioFormat.CHANNEL_OUT_MONO, AudioFormat.ENCODING_PCM_16BIT) | ||
| this.audioTrack = AudioTrack( | ||
| AudioManager.STREAM_MUSIC, 44100, AudioFormat.CHANNEL_OUT_MONO, |
There was a problem hiding this comment.
Would to be good to move 44100 to be a constant
| var phaseChange: Double | ||
|
|
||
| while(isPlaying) { | ||
| phaseChange = 2 * Math.PI * (frequency + detune) / 44100 |
| external fun initHybrid(l: Long): HybridData? | ||
|
|
||
| fun start() { | ||
| if(isPlaying) return |
There was a problem hiding this comment.
Suggested change
| if(isPlaying) return | |
| if (isPlaying) { | |
| return | |
| } |
:)
| } | ||
|
|
||
| fun stop() { | ||
| if(!isPlaying) return |
There was a problem hiding this comment.
Suggested change
| if(!isPlaying) return | |
| if (!isPlaying) { | |
| return | |
| } |
:)
…inject into js runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Implemented oscillator class in Kotlin containing whole sound generating logic and AudioContex native module which provides method for creating oscillator instance on JS side(
createOscillator( ))-Implemented c++ HybridClass for this oscillator
-Implemented jsi HostObject for this oscillator and injected it into js runtime
Issue: #16