Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/audio file and piano #232

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Fix/audio file and piano #232

merged 5 commits into from
Dec 10, 2024

Conversation

maciejmakowski2003
Copy link
Collaborator

@maciejmakowski2003 maciejmakowski2003 commented Dec 10, 2024 •
edited
Loading

Closes #

Introduced changes

  • Refactored and fixed Piano.tsx and `AudioFile.tsx' examples

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code

@maciejmakowski2003 maciejmakowski2003 self-assigned this Dec 10, 2024
michalsek
michalsek approved these changes Dec 10, 2024
View reviewed changes
apps/common-app/src/components/Button.tsx Outdated
return (
<Pressable
onPress={onPress}
onPress={disabled ? undefined : onPress}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onPress={disabled ? undefined : onPress}
disabled={disabled}
onPress={onPress}

@maciejmakowski2003 maciejmakowski2003 marked this pull request as ready for review December 10, 2024 15:06
@maciejmakowski2003 maciejmakowski2003 merged commit d79ab6f into main Dec 10, 2024
10 checks passed
@maciejmakowski2003 maciejmakowski2003 deleted the fix/audio-file-and-piano branch December 10, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsek michalsek michalsek approved these changes

Assignees

@maciejmakowski2003 maciejmakowski2003

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejmakowski2003 @michalsek